This repository was archived by the owner on Jun 19, 2025. It is now read-only.
Verbose vault logging - #502
Open
ramondeklein wants to merge 8 commits into
Open
Conversation
ramondeklein
force-pushed
the
verbose-vault-logging
branch
3 times, most recently
from
January 13, 2025 15:43
92eac4f to
7b779b6
Compare
ramondeklein
commented
Jan 13, 2025
ramondeklein
marked this pull request as ready for review
January 13, 2025 16:42
ramondeklein
force-pushed
the
verbose-vault-logging
branch
3 times, most recently
from
January 13, 2025 16:53
0cffa26 to
8295cbf
Compare
aead
suggested changes
Jan 29, 2025
aead
left a comment
aead
left a comment
Member
There was a problem hiding this comment.
LGTM, without the additional config field
aead
force-pushed
the
verbose-vault-logging
branch
from
January 30, 2025 09:29
8295cbf to
2c90351
Compare
ramondeklein
force-pushed
the
verbose-vault-logging
branch
from
February 3, 2025 11:19
2c90351 to
efb88c5
Compare
ramondeklein
force-pushed
the
verbose-vault-logging
branch
from
February 3, 2025 11:45
b673e09 to
9e44368
Compare
Contributor
Author
|
I processed the review comments. I find it kind of nasty to use |
Contributor
Author
|
@aead Not sure if we still need this. If not, then close. Otherwise please review... |
harshavardhana
force-pushed
the
master
branch
3 times, most recently
from
May 27, 2025 18:49
f832434 to
63649d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following functionality:
.keystore.vault.verbosetotrue(default is disabled).