image preview: show size/zoom status bar when preview is visible#309366
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
image preview: show size/zoom status bar when preview is visible#309366yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Previously the size and zoom status bar entries were shown only when the image preview editor was .active (focused). When the preview was visible in another editor group or in the background it was never .active, so the status bar stayed empty. Gate on .visible instead so the entries appear whenever the preview tab is on screen, matching the mental model users have from text editors. previewState transitions continue to track .active (Active vs Visible). Fixes microsoft#271120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When viewing images locally (for example, in a side-by-side group or while another editor has focus), the image preview's size and zoom status bar entries were missing. They only appeared while the preview webview was focused.
Root cause
ImagePreview.updateState()andMediaPreview.updateState()gatedshow()of the status bar entries onwebviewEditor.active(focused) rather thanwebviewEditor.visible(on screen). As soon as focus moved elsewhere, the entries were hidden.Fix
Switch the
show/hidegate for the size and zoom status bar entries towebviewEditor.visible. Keep thepreviewStatetransitions (ActivevsVisible) tied to.activesince that still reflects focus semantics used elsewhere.Fixes #271120