Skip to content

chore: prune unused dependencies and add knip to CI #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
heyitsaamir wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: prune unused dependencies and add knip to CI #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-test-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm install
- name: Check unused dependencies
run: npx knip
- name: Lint
run: npm run lint
- name: Build
Expand Down
4 changes: 0 additions & 4 deletions examples/http-adapters/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,13 @@
},
"dependencies": {
"@hono/node-server": "^1.19.13",
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.common": "*",
"cors": "^2.8.5",
"express": "^5.0.0",
"hono": "^4.12.14",
"restify": "^11.1.0"
},
"devDependencies": {
"@microsoft/teams.config": "*",
"@types/cors": "^2.8.17",
"@types/express": "^5.0.0",
"@types/node": "^22.5.4",
"@types/restify": "^8.5.12",
Expand Down
3 changes: 1 addition & 2 deletions examples/meetings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"dotenv": "^16.4.5",
"rimraf": "^6.0.1",
"tsx": "^4.20.6",
"typescript": "^5.4.5",
"env-cmd": "latest"
"typescript": "^5.4.5"
}
}
3 changes: 1 addition & 2 deletions examples/message-extensions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"dotenv": "^16.4.5",
"rimraf": "^6.0.1",
"tsx": "^4.20.6",
"typescript": "^5.4.5",
"env-cmd": "latest"
"typescript": "^5.4.5"
}
}
1 change: 0 additions & 1 deletion examples/proactive-messaging/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"dev": "tsx -r dotenv/config src/index.ts"
},
"dependencies": {
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.common": "*"
Expand Down
1 change: 0 additions & 1 deletion external/mcp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"jest": "^29.7.0",
"rimraf": "^6.0.1",
"ts-jest": "^29.2.5",
"tsup": "^8.4.0",
"typescript": "^5.4.5"
}
}
25 changes: 25 additions & 0 deletions knip.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import type { KnipConfig } from 'knip';

const config: KnipConfig = {
workspaces: {
'.': {
ignoreDependencies: ['@turbo/gen'],
},
'packages/devtools': {
// These are used but knip can't trace them through the Vite/React build pipeline
ignoreDependencies: [
'mdast-util-from-markdown',
'mdast-util-gfm',
'micromark-extension-gfm',
'react-markdown',
'remark-breaks',
'react-refresh',
'remark-gfm',
],
},
},
// Only check for unused dependencies — unlisted/unresolved are too noisy in a monorepo
include: ['dependencies', 'devDependencies'],
};

export default config;
Loading
Loading