Skip to content

.Net: fix: Fix AOT Compatibility - Remove Expression.Compile() from Brave/Tavily TextSearch #13541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markwallace-microsoft merged 3 commits into from
Feb 13, 2026
Merged

.Net: fix: Fix AOT Compatibility - Remove Expression.Compile() from Brave/Tavily TextSearch #13541

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff6d182
.Net: fix: Replace Expression.Compile() with NotSupportedException fo…
alzarei Feb 12, 2026
aaf6a14
fix: Remove unnecessary string interpolation in exception message
alzarei Feb 12, 2026
71ccd65
refactor: Address Copilot code review feedback
alzarei Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dotnet/src/Plugins/Plugins.Web/Brave/BraveTextSearch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,10 @@ private static void ExtractMethodCallClause(MethodCallExpression methodCall, Lis
System.Reflection.PropertyInfo property => property.GetValue(constantExpr.Value),
_ => null
},
_ => Expression.Lambda(expression).Compile().DynamicInvoke()
_ => throw new NotSupportedException(
$"Unable to extract value from expression of type '{expression.GetType().Name}'. " +
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other exceptions in this file (which report expression.NodeType), consider using expression.NodeType here instead of expression.GetType().Name. It tends to be a clearer indicator of what expression shape was rejected and matches the rest of the expression-analysis error messages.

Suggested change
$"Unable to extract value from expression of type '{expression.GetType().Name}'. " +
$"Unable to extract value from expression of node type '{expression.NodeType}'. " +

Copilot uses AI. Check for mistakes.
"Only constant expressions and simple member access are supported for AOT compatibility. " +
"Expression: " + expression)
Comment thread
markwallace-microsoft marked this conversation as resolved.
};
}

Expand Down
5 changes: 4 additions & 1 deletion dotnet/src/Plugins/Plugins.Web/Tavily/TavilyTextSearch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,10 @@ private static void ExtractMethodCallClause(MethodCallExpression methodCall, Lis
System.Reflection.PropertyInfo property => property.GetValue(constantExpr.Value),
_ => null
},
_ => Expression.Lambda(expression).Compile().DynamicInvoke()
_ => throw new NotSupportedException(
$"Unable to extract value from expression of type '{expression.GetType().Name}'. " +
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other exceptions in this file (which report expression.NodeType), consider using expression.NodeType here instead of expression.GetType().Name. NodeType will more directly identify unsupported patterns (e.g., Call, MemberAccess, Convert) and makes troubleshooting easier.

Suggested change
$"Unable to extract value from expression of type '{expression.GetType().Name}'. " +
$"Unable to extract value from expression of type '{expression.NodeType}'. " +

Copilot uses AI. Check for mistakes.
"Only constant expressions and simple member access are supported for AOT compatibility. " +
"Expression: " + expression)
Comment thread
markwallace-microsoft marked this conversation as resolved.
};
}

Expand Down
Loading