fix(docker): add healthcheck and restart policy to docker-compose.yml#2051
Open
sriram687 wants to merge 1 commit into
Open
fix(docker): add healthcheck and restart policy to docker-compose.yml#2051sriram687 wants to merge 1 commit into
sriram687 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds restart policies and healthchecks to the presidio-anonymizer and presidio-analyzer services in docker-compose.yml to improve service reliability and observability.
Changes:
- Adds
restart: unless-stoppedto both services - Adds HTTP healthcheck against
/healthendpoint for both services
Comment on lines
+27
to
+28
| healthcheck: | ||
| test: ["CMD", "curl", "-f", "http://localhost:5001/health"] |
Comment on lines
+26
to
+27
| restart: unless-stopped | ||
| healthcheck: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three related Docker configuration gaps across
docker-compose.ymlandDockerfile.transformers.Changes
1. Added healthcheck to docker-compose.yml
Both
presidio-analyzerandpresidio-anonymizerexpose a/healthendpoint but had no
healthcheckdefined in the compose file.2. Added restart policy to docker-compose.yml
Without a restart policy, a crashed container stays dead permanently.
+ restart: unless-stoppedFiles Changed
docker-compose.ymlhealthcheck+restartto both servicesRelated
Fixes #2050