feat(unrouteWebSocket): add missing API to match routeWebSocket#41176
Open
dcrousso wants to merge 2 commits into
Open
feat(unrouteWebSocket): add missing API to match routeWebSocket#41176dcrousso wants to merge 2 commits into
routeWebSocket#41176dcrousso wants to merge 2 commits into
Conversation
…ebSocket` this mirrors the existing `unroute` with it's corresponding `route`
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"4 flaky39523 passed, 775 skipped Merge workflow run. |
Contributor
Test results for "MCP"7266 passed, 1119 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this mirrors the pair of
routeandunroute/unrouteAllalso change
routeWebSocketto return aDisposableso that it can leverageusing(which again mirrorsroute)note that
unrouteWebSocket/unrouteAllWebSocketsonly affects newWebSocketopened after the API call (i.e. already openedWebSocketwill continue to be routed as before), which is the same behaviorroute/routeWebSocket/unroute/unrouteAll/etc. for in-flight requestsfixes #41158