fix(test): clarify error for test() after await in async describe#41145
Open
yury-s wants to merge 3 commits into
Open
fix(test): clarify error for test() after await in async describe#41145yury-s wants to merge 3 commits into
yury-s wants to merge 3 commits into
Conversation
When a test.describe() callback awaits before declaring tests, collection has already finished and test() throws the generic "did not expect test() to be called here" error, which is misleading. Add an explicit reason covering this case. Fixes: microsoft#41132
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Jun 4, 2026
Use a stricter, single-line reason: async test.describe() blocks are not supported, only sync ones.
Pin the message to the call that failed and keep it consistent with the other reasons in the list.
Contributor
Test results for "MCP"1 failed 7229 passed, 1103 skipped Merge workflow run. |
Contributor
Test results for "tests 1"4 flaky39553 passed, 771 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test()calls made after anawaitin anasync test.describe()callback run after test collection has finished, producing the misleading "Playwright Test did not expect test() to be called here" error.awaitor move async work into a hook.Fixes #41132