Skip to content

Improve Reshape and Slice folding #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justinchuby wants to merge 5 commits into
base: main
Choose a base branch
from

Address review comments: simplify sym_count check and use allowzero=1

4c7132d
Select commit
Loading
Failed to load commit list.
Open

Improve Reshape and Slice folding #2807

Address review comments: simplify sym_count check and use allowzero=1
4c7132d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 25, 2026 in 0s

71.75% (+0.09%) compared to f6a7de1

View this Pull Request on Codecov

71.75% (+0.09%) compared to f6a7de1

Details

Codecov Report

❌ Patch coverage is 91.93548% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.75%. Comparing base (f6a7de1) to head (4c7132d).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...er/rules/common/_materialize_reshape_shape_test.py 89.61% 1 Missing and 7 partials ⚠️
...nxscript/rewriter/rules/common/_collapse_slices.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2807      +/-   ##
==========================================
+ Coverage   71.66%   71.75%   +0.09%     
==========================================
  Files         238      240       +2     
  Lines       28864    28987     +123     
  Branches     2849     2867      +18     
==========================================
+ Hits        20686    20801     +115     
- Misses       7207     7208       +1     
- Partials      971      978       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov