Fix binary parameter truncation at embedded NUL in PDO emulated prepares (CWE-626) - #1675
Merged
Merged
Conversation
…res (CWE-626) pdo_sqlsrv_dbh_quote hex-encoded binary parameters but stopped at the first NUL byte, silently truncating data bound with SQLSRV_ENCODING_BINARY under emulated prepares. Encode the full length in both PHP version paths and add a regression test. (MSRC 125656)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1675 +/- ##
=======================================
Coverage 85.80% 85.80%
=======================================
Files 23 23
Lines 7251 7251
=======================================
Hits 6222 6222
Misses 1029 1029
🚀 New features to boost your workflow:
|
David-Engel
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdo_sqlsrv_dbh_quote hex-encoded binary parameters but stopped at the first NUL byte, silently truncating data bound with SQLSRV_ENCODING_BINARY under emulated prepares. Encode the full length in both PHP version paths and add a regression test. (MSRC 125656)