fix: decode percent-encoded file URIs before path conversion#1745
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: decode percent-encoded file URIs before path conversion#1745Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
This PR fixes issue #1738.
Problem
Before this change,
file_uri_to_path()passedparsed.pathdirectly intourl2pathname().That works for simple ASCII file paths, but breaks when the file URI contains
percent-encoded non-ASCII characters such as Korean filenames.
For example, a URI like:
file:///D:/.../%EC%A0%9C20...hwpxwas not being decoded into the original Unicode path before conversion
to a Windows filesystem path, causing the generated path to become invalid
and MCP failed to open the file.
Solution
Explicitly call
unquote(parsed.path)first, so the percent-encoded URI pathis restored to its real Unicode form before
url2pathname()convertsit into a local OS path.
In short:
Changes
unquoteto imports fromurllib.parseunquote()before passing tourl2pathname()感谢你们的奉献,希望能提供帮助。如果我解决得有问题或有待商妥的地方,请在下面留言,我会来处理。
Warmly,
RoomWithOutRoof