fix: decode percent-encoded URI path before converting to filesystem path#1743
Open
Jah-yee wants to merge 5 commits intomicrosoft:mainfrom
Open
fix: decode percent-encoded URI path before converting to filesystem path#1743Jah-yee wants to merge 5 commits intomicrosoft:mainfrom
Jah-yee wants to merge 5 commits intomicrosoft:mainfrom
Conversation
- Add helper function _format_cell_value() to preserve currency symbols - Support for USD ($), EUR (€), GBP (£), JPY (¥), and other currencies - Support for percentage formatting - Preserve decimal places from number format - Use openpyxl directly instead of pandas for better format control Fixes microsoft#53
- Extended accepts() to recognize youtu.be short URLs and /shorts/ URLs - Added _extract_video_id() helper to handle various YouTube URL formats - Now properly extracts video IDs from youtu.be, shorts, and standard watch URLs - Enables transcript fetching for short URLs
The git clone command used SSH URL (git@github.com:...), which requires SSH key authentication and fails for users without configured SSH keys. Changed to HTTPS URL (https://github.com/...) for better compatibility.
…path Fixes file URIs with Unicode filenames (e.g., Korean characters) not being decoded properly before conversion to Windows filesystem paths. Before: parsed.path was passed directly to url2pathname() while still percent-encoded, causing invalid paths for non-ASCII filenames. After: explicitly call unquote(parsed.path) first to restore the original Unicode form before url2pathname() converts to local OS path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
This PR fixes the issue where file URIs with Unicode filenames (e.g., Korean characters) were not being decoded properly before conversion to Windows filesystem paths.
Changes
unquoteimport fromurllib.parseunquote(parsed.path)before passing tourl2pathname()Problem
Before this fix,
parsed.pathwas passed directly tourl2pathname()while still percent-encoded, causing invalid paths for non-ASCII filenames like:file:///D:/.../%EC%A0%9C20...hwpxSolution
Explicitly call
unquote(parsed.path)first to restore the original Unicode form beforeurl2pathname()converts to local OS path.感谢你们的奉献，希望能提供帮助。如果我解决得有问题或有待商妥的地方，请在下面留言，我会来处理。
Warmly,
RoomWithOutRoof