fix: use HTTPS URL instead of SSH in README install instructions#1741
Open
Jah-yee wants to merge 4 commits intomicrosoft:mainfrom
Open
fix: use HTTPS URL instead of SSH in README install instructions#1741Jah-yee wants to merge 4 commits intomicrosoft:mainfrom
Jah-yee wants to merge 4 commits intomicrosoft:mainfrom
Conversation
- Add helper function _format_cell_value() to preserve currency symbols - Support for USD ($), EUR (€), GBP (£), JPY (¥), and other currencies - Support for percentage formatting - Preserve decimal places from number format - Use openpyxl directly instead of pandas for better format control Fixes microsoft#53
- Extended accepts() to recognize youtu.be short URLs and /shorts/ URLs - Added _extract_video_id() helper to handle various YouTube URL formats - Now properly extracts video IDs from youtu.be, shorts, and standard watch URLs - Enables transcript fetching for short URLs
The git clone command used SSH URL (git@github.com:...), which requires SSH key authentication and fails for users without configured SSH keys. Changed to HTTPS URL (https://github.com/...) for better compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
I noticed the README.md file uses an SSH URL for cloning the repository, which requires SSH key authentication and fails for users without configured SSH keys.
This fix changes the git clone command from:
to:
This makes the installation instructions work for all users, regardless of SSH key configuration.
Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly,
RoomWithOutRoof