ci: update actions and golangci-lint, and fix linting#349
Open
thaJeztah wants to merge 14 commits intomicrosoft:mainfrom
Open
ci: update actions and golangci-lint, and fix linting#349thaJeztah wants to merge 14 commits intomicrosoft:mainfrom
thaJeztah wants to merge 14 commits intomicrosoft:mainfrom
Conversation
Contributor
thaJeztah
commented
Mar 23, 2026
thaJeztah
commented
- supersedes, closes Bump golangci/golangci-lint-action from 4 to 9 #344
- supersedes, closes Bump actions/setup-go from 5 to 6 #343
- supersedes, closes Bump actions/checkout from 4 to 6 #342
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
```
file.go:237:41: identical-ifelseif-branches: "if...else if" chain with identical branches (lines 237 and 239) (revive)
if err == nil && n == 0 && len(b) != 0 {
return 0, io.EOF
} else if err == windows.ERROR_BROKEN_PIPE { //nolint:errorlint // err is Errno
```
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
``` backup_test.go:23:2: redundant-test-main-exit: redundant call to os.Exit in TestMain function, the test runner will handle it automatically as of Go 1.15 (revive) os.Exit(m.Run()) ^ ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
``` tools/mkwinsyscall/mkwinsyscall.go:791:12: SA1019: runtime.GOROOT has been deprecated since Go 1.24: The root used during the Go build will not be meaningful if the binary is copied to another machine. Use the system path to locate the “go” binary, and use “go env GOROOT” to find its GOROOT. (staticcheck) goroot := runtime.GOROOT() ^ ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- update actions to current version - update golangci-lint config to v2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.