Skip to content

Fix headless Toast e2e selector ambiguity #36644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
+11 −12
Closed

Fix headless Toast e2e selector ambiguity #36644

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
093ccd7
Initial plan
Copilot Aug 28, 2026
aa8d571
Fix Toast Cypress selector
Copilot Aug 28, 2026
2502d68
Use single ToastContainer test selector
Copilot Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions ...ct-components/react-headless-components-preview/library/src/components/Toast/Toast.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@ import { Provider } from '../Provider';
/**
* Selectors used by the headless tests. Unlike the styled v9 layer, the headless
* Toast does not emit Griffel class names — we target structural roles and the
* `data-intent` attribute the headless `Toast` adds to its root.
* structural roles on the headless `ToastContainer` root.
*/
const TOAST_CONTAINER = '[role="listitem"]';
const TOAST = '[data-intent]';

const mount = (element: JSXElement) =>
mountBase(
Expand Down Expand Up @@ -43,7 +42,7 @@ describe('Toast (headless)', () => {
};

mount(<Example />);
cy.get('button').click().get(TOAST).should('exist');
cy.get('button').click().get(TOAST_CONTAINER).should('exist');
});

it('should dismiss toast', () => {
Expand Down Expand Up @@ -73,8 +72,8 @@ describe('Toast (headless)', () => {
};

mount(<Example />);
cy.get('#make').click().get(TOAST).should('exist');
cy.get('#dismiss').click().get(TOAST).should('not.exist');
cy.get('#make').click().get(TOAST_CONTAINER).should('exist');
cy.get('#dismiss').click().get(TOAST_CONTAINER).should('not.exist');
});

it('should dismiss all toasts', () => {
Expand Down Expand Up @@ -105,8 +104,8 @@ describe('Toast (headless)', () => {
};

mount(<Example />);
cy.get('#make').click().get(TOAST).should('have.length', 5);
cy.get('#dismiss').click().get(TOAST).should('not.exist');
cy.get('#make').click().get(TOAST_CONTAINER).should('have.length', 5);
cy.get('#dismiss').click().get(TOAST_CONTAINER).should('not.exist');
});

it('should play and pause toast', () => {
Expand Down Expand Up @@ -138,9 +137,9 @@ describe('Toast (headless)', () => {
};

mount(<Example />);
cy.get('#make').click().get(TOAST).should('exist');
cy.get('#pause').click().wait(1000).get(TOAST).should('exist');
cy.get('#play').click().get(TOAST).should('not.exist');
cy.get('#make').click().get(TOAST_CONTAINER).should('exist');
cy.get('#pause').click().wait(1000).get(TOAST_CONTAINER).should('exist');
cy.get('#play').click().get(TOAST_CONTAINER).should('not.exist');
});

it('should update toast content', () => {
Expand Down Expand Up @@ -178,7 +177,7 @@ describe('Toast (headless)', () => {
};

mount(<Example />);
cy.get('#make').click().get(TOAST).should('exist');
cy.get('#make').click().get(TOAST_CONTAINER).should('exist');
cy.get('#update').click().get('body').contains('Foo');
});

Expand All @@ -204,7 +203,7 @@ describe('Toast (headless)', () => {
};

mount(<Example />);
cy.get('#make').click().get(TOAST).trigger('mouseenter').wait(700).get(TOAST).should('exist');
cy.get('#make').click().get(TOAST_CONTAINER).trigger('mouseenter').wait(700).get(TOAST_CONTAINER).should('exist');
});

it('should follow lifecycle', () => {
Expand Down
Loading