fix(react-headless-components-preview): improve Toast focus accessibility - #36638
Open
Dmytro Kirpa (dmytrokirpa) wants to merge 3 commits into
Open
fix(react-headless-components-preview): improve Toast focus accessibility#36638Dmytro Kirpa (dmytrokirpa) wants to merge 3 commits into
Dmytro Kirpa (dmytrokirpa) wants to merge 3 commits into
Conversation
…while focus is in a toast stack
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
Tudor Popa (tudorpopams)
requested a review
from Paul Mardling (PaulGMardling)
August 27, 2026 11:27
Paul Mardling (PaulGMardling)
approved these changes
Aug 27, 2026
Copilot started reviewing on behalf of
Dmytro Kirpa (dmytrokirpa)
August 27, 2026 14:57
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds keyboard-accessible toast-stack navigation and focus-driven timeout pausing to the headless preview package.
Changes:
- Adds native
focusgroupattributes while preserving list semantics. - Pauses/resumes toast timers as focus enters/leaves a stack.
- Adds unit, Cypress, and Beachball coverage.
Merge confidence: 55/100 due to unresolved timer edge cases and missing keyboard-navigation coverage.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Toast/useToast.ts |
Excludes nested toast controls from outer focus navigation. |
Toast/Toaster/useToaster.tsx |
Adds focusgroup navigation and focus-based timer handling. |
Toast/Toaster/Toaster.test.tsx |
Tests stack focusgroup semantics. |
Toast/Toast.test.tsx |
Tests nested focusgroup opt-out. |
Toast/Toast.cy.tsx |
Tests focus-driven timeout behavior. |
change/@fluentui-react-headless-components-preview-8f342829-73a2-4dc2-951d-9c89fcfe5321.json |
Records the patch release. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+64
to
+67
| const onFocus = useEventCallback((e: React.FocusEvent<HTMLDivElement>) => { | ||
| if (!e.currentTarget.contains(e.relatedTarget)) { | ||
| pauseAllToasts(); | ||
| } |
Comment on lines
+70
to
+73
| const onBlur = useEventCallback((e: React.FocusEvent<HTMLDivElement>) => { | ||
| if (!e.currentTarget.contains(e.relatedTarget)) { | ||
| playAllToasts(); | ||
| } |
| {toast.content as React.ReactNode} | ||
| </ToastContainer> | ||
| )), | ||
| focusgroup: 'toolbar block itemcontrols', |
Copilot started reviewing on behalf of
Dmytro Kirpa (dmytrokirpa)
August 29, 2026 11:42
View session
Comment on lines
82
to
85
| const activeElement = targetDocument?.activeElement; | ||
| const containsActive = !!(activeElement && toastRef.current?.contains(activeElement)); | ||
| const containsActive = !!(activeElement && toastRef.current?.parentElement?.contains(activeElement)); | ||
| if (!containsActive) { | ||
| setRunning(true); |
| const pause = useEventCallback(() => setRunning(false)); | ||
| const play = useEventCallback(() => { | ||
| if (imperativePauseRef.current) { | ||
| if (imperativePauseRef.current || hoverPauseRef.current || windowBlurPauseRef.current) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
focusgroup="toolbar block itemcontrols"navigation to headless toast stacks while preservinglist/listitemsemanticsfocusgroup="none"Validation
yarn nx run react-headless-components-preview:lintyarn nx run react-headless-components-preview:test --runTestsByPath src/components/Toast/Toast.test.tsx src/components/Toast/Toaster/Toaster.test.tsx --runInBand(25 tests passed)yarn nx run react-headless-components-preview:e2e --spec "src/components/Toast/Toast.cy.tsx"(11 tests passed)./node_modules/.bin/beachball check