Fix Dropdown filled boundary in high contrast themes - #36637
Open
Bernardo Sunderhus (bsunderhus) wants to merge 1 commit into
Open
Fix Dropdown filled boundary in high contrast themes#36637Bernardo Sunderhus (bsunderhus) wants to merge 1 commit into
Bernardo Sunderhus (bsunderhus) wants to merge 1 commit into
Conversation
Bernardo Sunderhus (bsunderhus)
requested review from
a team and
Dmytro Kirpa (dmytrokirpa)
as code owners
August 27, 2026 09:29
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
Dmytro Kirpa (dmytrokirpa)
approved these changes
Aug 27, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 413 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 193 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 744 | Changed |
vr-tests-react-components/ProgressBar converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 33 | Changed |
vr-tests-react-components/TagPicker 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1319 | Changed |
There were 1 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Dropdowncontrols usingappearance="filled-darker"orappearance="filled-lighter"used a literal transparent border. In Teams high contrast, this made the resting boundary invisible for filled appearances.New Behavior
Filled
Dropdownappearances now usetokens.colorTransparentStroke, matchingCombobox,Input, andTextarea, so high contrast themes can render a visible resting boundary.Related Issue
Fixes #36636
Validation
components-dropdown--appearanceandstorybook_fluentui-react-addon_theme:teams-high-contrast;filled-darkernow computes to a visible white solid border.yarn nx run react-combobox:test.