chore(deps): ban nx packages from dependabot updates - #1225
Open
Martin Hochel (Hotell) wants to merge 1 commit into
Open
chore(deps): ban nx packages from dependabot updates#1225Martin Hochel (Hotell) wants to merge 1 commit into
Martin Hochel (Hotell) wants to merge 1 commit into
Conversation
📋 PR Validation SummaryCheck the Build react library job summary for detailed reports:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot's grouped updates are working well, but the
development-dependenciesgroup keepssweeping Nx along with everything else — see #1223, which bundles
nx,@nx/jsand@nx/eslint-pluginin with 19 unrelated bumps.Nx can't be upgraded that way.
yarn nx migrateis what keeps thenxruntime and every@nx/*plugin version-locked to each other, and it's also what applies the config codemods
(
nx.json,project.json,migrations.json). Dependabot only rewritespackage.jsonandyarn.lock, so it silently skips the codemods and can leave plugins desynced from the runtime.Change
Adds an ignore rule for
nx,@nx/*and@nrwl/*to the npm ecosystem in.github/dependabot.yml.Deliberately no
update-typesfilter, unlike the existing major-version rule above it. Thatmakes the ban total — security updates included — because those need to go through
nx migratejust the same.
@nrwl/*is listed pre-emptively; nothing in the repo depends on the legacy scopetoday.
Ignore rules are evaluated before grouping, so these drop out of
development-dependenciesratherthan forming a group of their own.
Verification
Parsed the config with
js-yamlto confirm it's valid and the rules land on the npm entry:[ { "dependency-name": "*", "update-types": ["version-update:semver-major"] }, { "dependency-name": "nx" }, { "dependency-name": "@nx/*" }, { "dependency-name": "@nrwl/*" } ]Follow-up
#1223 won't self-correct — it needs
@dependabot recreate(or a close/reopen) once this lands sothe group is rebuilt without the Nx bumps.