feat(spec render): Add supporting infrastructure for rendered specs#16674
Merged
christopherco merged 3 commits intomicrosoft:tomls/base/mainfrom Apr 25, 2026
Merged
Conversation
597debd to
01977e4
Compare
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. |
2 similar comments
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. |
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. |
705d31a to
b404f99
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class “rendered specs” support to the repo by defining a canonical rendered output directory, documenting how developers should use it, and introducing CI infrastructure to detect rendered-spec drift and comment on PRs.
Changes:
- Add
rendered-specs-dirto the base project config and documentspecs/as the rendered-specs location. - Introduce fork-PR-safe CI workflows + container tooling to render specs, detect drift, and post/update a PR comment (with patch artifact).
- Update agent skills/prompts/instructions to prefer
comp renderas the fast verification loop for overlays.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| base/project.toml | Adds rendered-specs-dir pointing rendered output to repo-root specs/. |
| README.md | Documents specs/ and basic “install azldev / render specs” workflow; fixes list formatting. |
| AGENTS.md | Updates verification guidance to prefer render over prep-sources for overlay iteration. |
| .gitignore | Ignores .hyenas/ directory. |
| .github/workflows/scripts/post_render_comment.py | Posts/updates/deletes a PR comment summarizing rendered-spec drift; includes size/path safety mechanisms. |
| .github/workflows/scripts/check_rendered_specs.py | Detects drift between committed vs rendered specs, filters timestamp noise, emits JSON report and optional patch. |
| .github/workflows/containers/azldev-runner.Dockerfile | Minimal container image for running azldev workflows (git/mock/python/sudo). |
| .github/workflows/check-rendered-specs.yml | Reusable workflow to render specs in a container, compute drift, upload artifacts, and post PR comments. |
| .github/workflows/check-rendered-specs-stub.yml | pull_request_target stub delegating to the reusable workflow for fork safety. |
| .github/skills/skill-fix-overlay/SKILL.md | Updates overlay-debug workflow to use render first, prep-sources for deep diffing. |
| .github/skills/skill-build-component/SKILL.md | Updates inner loop and debugging steps to prefer render for fast verification. |
| .github/skills/skill-add-component/SKILL.md | Adds render-based validation guidance for new components/overlays. |
| .github/prompts/azl-update-component.prompt.md | Adds comp render to overlay verification steps. |
| .github/prompts/azl-debug-component.prompt.md | Adds comp render as first step to classify overlay-related failures. |
| .github/prompts/azl-add-component.prompt.md | Updates validation guidance to render + inspect specs/. |
| .github/instructions/spec.instructions.md | Narrows hand-maintained spec instructions to base/**/*.spec (excludes rendered specs). |
| .github/instructions/rendered-specs.instructions.md | New instructions for specs/**/* emphasizing generated/read-only nature. |
| .github/instructions/pr-check-workflows.instructions.md | New workflow security guidelines (stub+reusable pattern, container isolation, comment hardening). |
| .github/copilot-instructions.md | Documents specs/ layout and adds render commands to quick reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b404f99 to
44e3587
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9c9df22 to
eee2a95
Compare
PawelWMS
reviewed
Apr 17, 2026
PawelWMS
reviewed
Apr 17, 2026
PawelWMS
reviewed
Apr 17, 2026
PawelWMS
reviewed
Apr 17, 2026
PawelWMS
reviewed
Apr 17, 2026
PawelWMS
reviewed
Apr 17, 2026
806114b to
64b62b1
Compare
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
reviewed
Apr 20, 2026
PawelWMS
approved these changes
Apr 21, 2026
Co-authored-by: Pawel Winogrodzki <pawelwi@microsoft.com>
5a140fb to
c064a4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.