Skip to content

feat(packages): add package publish annotation support #16549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liunan-ms wants to merge 1 commit into
base: tomls/base/main
Choose a base branch
from
+76 −1
Open

feat(packages): add package publish annotation support #16549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions base/comps/wget2/wget2.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@
[components.wget2.build]
# Supply the wget compatibility package.
with = ["as_wget"]

# Component level configuration
[components.wget2.packages.wget2-wget.publish]
channel = "rpm-base"
71 changes: 71 additions & 0 deletions base/packages-demo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
#
# packages-demo.toml — Example of packages.toml with a small subset of packages.
#
# This file demonstrates how azldev splits binary packages across publish
# repositories using package groups. Each [package-groups.<name>] section
# assigns a set of packages to a publish channel.

# The real packages.toml will be added in the future.
#
Comment on lines +2 to +9
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header comments describe this as an example/small subset and say "The real packages.toml will be added in the future", but the file is now included by default via base/project.toml. That makes it effectively production config; consider renaming it to packages.toml (and treating it as authoritative) or updating the comments to clearly state it is intentionally active and what scope it is expected to cover.

Suggested change
# packages-demo.toml — Example of packages.toml with a small subset of packages.
#
# This file demonstrates how azldev splits binary packages across publish
# repositories using package groups. Each [package-groups.<name>] section
# assigns a set of packages to a publish channel.
# The real packages.toml will be added in the future.
#
# packages-demo.toml — Active package publish configuration for this project.
#
# This file defines how azldev splits binary packages across publish
# repositories using package groups. Each [package-groups.<name>] section
# assigns a set of packages to a publish channel.
#
# It is intentionally active when included by the project, but currently
# covers only a small subset of packages. Expand this file as additional
# package publish groups are defined.
#

Copilot uses AI. Check for mistakes.
# Package publish configuration
#

# Project-wide baseline — unpublished unless overridden by a package group
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment says packages are "unpublished unless overridden by a package group", but publish settings can also be overridden at the component/per-package level (as shown in wget2.comp.toml). Consider updating the comment to reflect the actual precedence so readers don't miss component-level overrides.

Suggested change
# Project-wide baseline — unpublished unless overridden by a package group
# Project-wide baseline — unpublished unless overridden by a package group
# or by more specific component/per-package publish settings.

Copilot uses AI. Check for mistakes.
[default-package-config]
publish = { channel = "none" }

# Packages published to rpm-base
[package-groups.base-packages]
description = "base packages"
packages = [
"kernel",
"kernel-core",
"kernel-cross-headers",
"kernel-debug",
"kernel-debug-core",
"kernel-debug-devel",
"kernel-debug-devel-matched",
"kernel-debug-modules",
"kernel-debug-modules-core",
"kernel-debug-modules-extra",
"kernel-debug-uki-virt",
"kernel-devel",
"kernel-devel-matched",
"kernel-doc",
"kernel-headers",
"kernel-modules",
"kernel-modules-core",
"kernel-modules-extra",
"kernel-modules-extra-matched",
"kernel-rpm-macros",
"kernel-srpm-macros",
"kernel-tools",
"kernel-tools-libs",
"kernel-tools-libs-devel",
"kernel-uki-virt",
"kernel-uki-virt-addons",
"libcurl",
"libcurl-devel",
"libcurl-minimal",
"wget2",
"wget2-libs",
"which",
"whois"
]

[package-groups.base-packages.default-package-config.publish]
channel = "rpm-base"

# Packages published to rpm-build-only
[package-groups.build-only-packages]
description = "build-only packages"
packages = [
"kernel-debug-modules-internal",
"kernel-debug-uki-virt-addons",
"kernel-modules-internal",
"kernel-selftests-internal",
"wget2-devel"
]

[package-groups.build-only-packages.default-package-config.publish]
channel = "rpm-build-only"
2 changes: 1 addition & 1 deletion base/project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Base project
#

includes = ["comps/components.toml", "images/images.toml"]
includes = ["comps/components.toml", "images/images.toml", "packages-demo.toml"]
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including packages-demo.toml in the project includes makes this "demo" config active for all builds. Since it sets a project-wide [default-package-config] publish.channel = "none", any package not explicitly listed/overridden will be marked as unpublished, which can unintentionally change downstream publishing behavior. If this file is meant to be documentation-only, avoid including it by default (or make the demo non-impacting by removing the default publish override).

Suggested change
includes = ["comps/components.toml", "images/images.toml", "packages-demo.toml"]
includes = ["comps/components.toml", "images/images.toml"]

Copilot uses AI. Check for mistakes.

[project]
description = 'azurelinux-base'
Expand Down
Loading