chore: upgrade typescript-eslint to v8.46.2 and fix lint errors#7692
Closed
v-sohmondal wants to merge 1 commit intomainfrom
Closed
chore: upgrade typescript-eslint to v8.46.2 and fix lint errors#7692v-sohmondal wants to merge 1 commit intomainfrom
v-sohmondal wants to merge 1 commit intomainfrom
Conversation
- Upgraded @typescript-eslint/parser from v6.21.0 to v8.46.2 - Upgraded @typescript-eslint/eslint-plugin from v5.62.0 to v8.46.2 - Updated eslintrc.base.js configuration for v8 compatibility: - Changed parserOptions.project to projectService: true - Renamed recommended-requiring-type-checking to recommended-type-checked - Replaced deprecated rules (ban-types, no-var-requires) - Added override for JS files with disable-type-checked - Updated ecmaVersion from 8 to 2020 Fixed 68 lint errors introduced by stricter v8 rules: - prefer-promise-reject-errors (29): Wrapped Promise.reject() calls with Error objects - no-base-to-string (15): Added proper stringification for objects - no-unused-expressions (14): Added void operator for intentional side-effect expressions - no-redundant-type-constituents (6): Removed redundant type unions - no-unsafe-enum-comparison (3): Added type assertions for enum comparisons - only-throw-error (1): Wrapped error string in Error object
v-sohmondal
deleted the
users/v-sohmondal/upgrade-typescript-eslint-v8
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgraded
@typescript-eslint/parserand@typescript-eslint/eslint-pluginto v8.46.2 to resolve version conflicts and enable stricter type-checking rules.Dependency Updates:
@typescript-eslint/parser: v6.21.0 → v8.46.2@typescript-eslint/eslint-plugin: v5.62.0 → v8.46.2Configuration Changes (eslintrc.base.js):
projectService: true(replaces deprecatedprojectoption)recommended-type-checked(renamed fromrecommended-requiring-type-checking)@typescript-eslint/ban-typeswith@typescript-eslint/no-empty-object-type,@typescript-eslint/no-wrapper-object-types, and@typescript-eslint/no-unsafe-function-type@typescript-eslint/no-var-requireswith@typescript-eslint/no-require-importstsconfigRootDir: __dirnamefor proper path resolutionecmaVersionfrom 8 to 2020.jsfiles withdisable-type-checkedLint Error Fixes (68 errors across 48 files):
All errors were properly fixed without disabling any rules.
Details
This upgrade resolves conflicts introduced by Dependabot PRs #7686 and #7687, which attempted to upgrade the parser and plugin separately to different major versions. The v8 upgrade brings stricter type-checking that improves code quality.
Motivation
Addresses version mismatch between
@typescript-eslint/parser(v6) and@typescript-eslint/eslint-plugin(v5), and enables modern typescript-eslint features and stricter type safety checks.Context
No functionality is left out-of-scope. All 68 lint errors introduced by v8's stricter rules have been properly addressed without disabling any rules, ensuring improved code quality throughout the codebase.
Pull request checklist
yarn fastpassyarn test) - n/a (dependency upgrade with lint fixes)<rootDir>/test-results/unit/coverage- n/a (no logic changes)fix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.