Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/common/types/store-data/card-view-model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,5 @@ export const AllRuleResultStatuses: CardRuleResultStatus[] = [
'fail',
'unknown',
'inapplicable',
];
'incomplete'
];
1 change: 1 addition & 0 deletions src/common/types/store-data/unified-data-interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export interface UnifiedResult {
export type InstanceResultStatus =
| 'pass' // May include results which are very low-confidence failures, in addition to high-confidence non-failures
| 'fail'
| 'incomplete'
| 'unknown';

export interface ScreenshotData {
Expand Down
5 changes: 5 additions & 0 deletions src/injected/adapters/scan-results-to-unified-results.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ export class ConvertScanResultsToUnifiedResults {
'pass',
this.getFixResolution,
),
...this.createUnifiedResultsFromRuleResults(
scanResults.incomplete,
'incomplete',
this.getFixResolution,
)
];
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { ContentContainer } from './content-container';
import { DetailsSection } from './details-section';
import { NotApplicableChecksSection } from './not-applicable-checks-section';
import { PassedChecksSection } from './passed-checks-section';
import { IncompleteChecksSection } from './incomplete-checks-section';
import { ReportFooter } from './report-footer';
import { ReportSectionFactory } from './report-section-factory';
import { ResultsContainer } from './results-container';
Expand All @@ -24,9 +25,10 @@ export const AxeResultsReportSectionFactory: ReportSectionFactory = {
ResultsContainer,
FailedInstancesSection,
PassedChecksSection,
IncompleteChecksSection,
NotApplicableChecksSection,
FooterSection: ReportFooter,
resultSectionsOrder: ['failed', 'passed', 'notApplicable'],
resultSectionsOrder: ['failed', 'passed', 'incomplete', 'notApplicable'],
FooterText: FooterTextForService,
HeaderSection: ReporterHeaderSection,
HeadSection: ReporterHead,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,8 @@ export const CombinedReportNotApplicableSection = makeCombinedReportRulesOnlySec
outcomeType: 'inapplicable',
title: 'Not applicable rules',
});

export const CombinedReportIncompleteSection = makeCombinedReportRulesOnlySection({
outcomeType: 'incomplete',
title: 'Incomplete rules',
});
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
import {
CombinedReportNotApplicableSection,
CombinedReportPassedSection,
CombinedReportIncompleteSection,
} from 'reports/components/report-sections/combined-report-rules-only-sections';
import { CombinedReportSummarySection } from 'reports/components/report-sections/combined-report-summary-section';
import { RulesResultsContainer } from 'reports/components/report-sections/rules-results-container';
Expand Down Expand Up @@ -48,8 +49,9 @@ export const CombinedReportSectionFactory: ReportSectionFactory<CombinedReportSe
ResultsContainer: RulesResultsContainer,
FailedInstancesSection: CombinedReportFailedSection,
PassedChecksSection: CombinedReportPassedSection,
IncompleteChecksSection: CombinedReportIncompleteSection,
NotApplicableChecksSection: CombinedReportNotApplicableSection,
FooterSection: ReportFooter,
FooterText: FooterTextForService,
resultSectionsOrder: ['failed', 'passed', 'notApplicable'],
resultSectionsOrder: ['failed', 'passed', 'incomplete', 'notApplicable'],
};
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const IncompleteChecksSection = NamedFC<IncompleteChecksSectionProps>(
'IncompleteChecksSection',
({ deps, cardsViewData, cardSelectionMessageCreator, testKey, sectionHeadingLevel }) => {
const cardRuleResults = cardsViewData?.cards?.unknown ?? [];

return (
<CollapsibleResultSection
deps={deps}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@ import { CardsViewModel } from '../../../common/types/store-data/card-view-model
import { UserConfigurationStoreData } from '../../../common/types/store-data/user-configuration-store';
import { NotApplicableChecksSectionDeps } from './not-applicable-checks-section';
import { PassedChecksSectionDeps } from './passed-checks-section';
import { IncompleteChecksSectionDeps } from './incomplete-checks-section';

export type SectionDeps = NotApplicableChecksSectionDeps &
CommonInstancesSectionDeps &
PassedChecksSectionDeps;
PassedChecksSectionDeps &
IncompleteChecksSectionDeps;

export type SectionProps = {
deps: SectionDeps;
Expand All @@ -39,6 +41,7 @@ export type SectionProps = {
export const ResultSectionTypes = {
failed: 'FailedInstancesSection',
passed: 'PassedChecksSection',
incomplete: 'IncompleteChecksSection',
notApplicable: 'NotApplicableChecksSection',
};

Expand All @@ -53,6 +56,7 @@ export type ReportSectionFactory<SectionPropsType = SectionProps> = {
ResultsContainer: ReactFCWithDisplayName<SectionPropsType>;
FailedInstancesSection: ReactFCWithDisplayName<SectionPropsType>;
PassedChecksSection: ReactFCWithDisplayName<SectionPropsType>;
IncompleteChecksSection: ReactFCWithDisplayName<SectionPropsType>;
NotApplicableChecksSection: ReactFCWithDisplayName<SectionPropsType>;
FooterSection: ReactFCWithDisplayName;
FooterText: ReactFCWithDisplayName<SectionPropsType>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export const SummaryReportSectionFactory: ReportSectionFactory<SummaryReportSect
ResultsContainer: ResultsByUrlContainer,
FailedInstancesSection: FailedUrlsSection,
PassedChecksSection: PassedUrlsSection,
IncompleteChecksSection: NotScannedUrlsSection,
NotApplicableChecksSection: NotScannedUrlsSection,
FooterSection: ReportFooter,
FooterText: FooterTextForService,
Expand Down
Loading