CLI: Initial support for volume commands

[AmelBawa-msft]

Summary of the Pull Request

PR Checklist

• Closes: Link to issue #xxx
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated if needed and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated if needed
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[Copilot]

Pull request overview

Adds initial WSLC CLI support for managing named volumes (create/list/inspect/remove) and validates the new --driver argument, with E2E coverage to ensure named volumes can be used across containers.

Changes:

• Introduces new wslc volume command group with create/remove/inspect/list subcommands.
• Adds volume task/service/model plumbing to call existing session COM volume APIs and render output (table/json/quiet).
• Extends Windows E2E tests to validate named volume persistence across container runs/creates.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/windows/wslc/e2e/WSLCE2EContainerRunTests.cpp	Adds E2E scenarios validating named-volume write/read and multi-container persistence with container run.
test/windows/wslc/e2e/WSLCE2EContainerCreateTests.cpp	Adds E2E scenarios validating named-volume persistence across container create/start and subsequent containers.
src/windows/wslc/tasks/VolumeTasks.h	Declares volume task entry points used by the new commands.
src/windows/wslc/tasks/VolumeTasks.cpp	Implements volume tasks: create/delete/list/inspect, including output formatting (table/json/quiet).
src/windows/wslc/services/VolumeService.h / .cpp	Adds service wrapper over session COM APIs for volume CRUD/list/inspect.
src/windows/wslc/services/VolumeModel.h	Introduces VolumeInformation model for list output + JSON serialization.
src/windows/wslc/core/ExecutionContextData.h	Adds Data::Volumes mapping to store volume lists in the execution context.
src/windows/wslc/commands/VolumeCommand.*	Adds root volume command and wires up subcommands.
src/windows/wslc/commands/Volume*Command.cpp	Implements argument sets, descriptions, validation, and task pipelines for each volume subcommand.
src/windows/wslc/commands/RootCommand.cpp	Registers volume under the CLI root.
src/windows/wslc/arguments/ArgumentDefinitions.h	Adds VolumeDriver (--driver/-d) and positional VolumeName.
src/windows/wslc/arguments/ArgumentValidation.h / .cpp	Adds validation for the --driver argument (currently supports vhd).
localization/strings/en-US/Resources.resw	Adds localized help text for volume commands and new arguments.

[Copilot]

Task.h is included but not used in this header (unlike ContainerTasks.h, which defines a Task-derived type). Dropping the unused include would reduce unnecessary coupling and rebuilds.

Suggested change

#include "Task.h"

[Copilot]

<wslc.h> doesn’t appear to be needed for VolumeInformation (it only uses std::string and the nlohmann JSON macro). Consider removing the unused include to keep the model header lightweight, consistent with other model headers like ImageModel.h.

Suggested change

#include <wslc.h>

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 11 comments.

[Copilot]

The new short options introduce an unambiguous parsing conflict: --opt uses -o, which is already used by --output. Similarly, --driver uses -d, which is already used by the existing --detach argument. Short-option collisions typically make argument parsing ambiguous or cause one flag to shadow the other. Fix by assigning unused short options (or NO_ALIAS) to Driver and Options.

[Copilot]

New end-user facing strings are hardcoded for --driver and --opt while nearby args use Localization::... accessors. This breaks localization consistency (and the PR checklist item). Prefer using localized resources for these descriptions (there is already WSLCCLI_VolumeDriverArgDescription in Resources.resw; --opt should get a similar resource).

Suggested change

	_(Driver, "driver", L"d", Kind::Value, L"Specify volume driver name (default vhd)") \
	_(Driver, "driver", L"d", Kind::Value, Localization::WSLCCLI_VolumeDriverArgDescription()) \

[Copilot]

New end-user facing strings are hardcoded for --driver and --opt while nearby args use Localization::... accessors. This breaks localization consistency (and the PR checklist item). Prefer using localized resources for these descriptions (there is already WSLCCLI_VolumeDriverArgDescription in Resources.resw; --opt should get a similar resource).

[Copilot]

These new assertions use S_OK for .ExitCode, while similar E2E tests in the other file use numeric process exit codes (0/1). Even though S_OK and 0 are equivalent, mixing conventions makes the tests harder to read and can confuse expectations about whether .ExitCode is an HRESULT or a process exit code. Consider standardizing on one representation across the E2E suite.

[Copilot]

These new assertions use S_OK for .ExitCode, while similar E2E tests in the other file use numeric process exit codes (0/1). Even though S_OK and 0 are equivalent, mixing conventions makes the tests harder to read and can confuse expectations about whether .ExitCode is an HRESULT or a process exit code. Consider standardizing on one representation across the E2E suite.

[Copilot]

These new assertions use S_OK for .ExitCode, while similar E2E tests in the other file use numeric process exit codes (0/1). Even though S_OK and 0 are equivalent, mixing conventions makes the tests harder to read and can confuse expectations about whether .ExitCode is an HRESULT or a process exit code. Consider standardizing on one representation across the E2E suite.

[Copilot]

These tests rely on explicit cleanup at the end of the method. If a Verify(...) throws/fails mid-test, the final cleanup line won’t execute, which can leave volumes behind and cause later E2E runs to become flaky (e.g., name collisions). A more robust pattern is to use a scope guard/RAII cleanup so volume rm always runs even on early failure.

[Copilot]

These tests rely on explicit cleanup at the end of the method. If a Verify(...) throws/fails mid-test, the final cleanup line won’t execute, which can leave volumes behind and cause later E2E runs to become flaky (e.g., name collisions). A more robust pattern is to use a scope guard/RAII cleanup so volume rm always runs even on early failure.

[Copilot]

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.

[Copilot]

This introduces a command-specific format validation that duplicates logic already centralized in validation::GetFormatTypeFromString(...) (used later by ListVolumes). To avoid drift/inconsistent error details, prefer using the shared validation helper here as well (or remove this override and rely on the existing validation path).

Suggested change

	if (execArgs.Contains(ArgType::Format))
	{
	auto format = execArgs.Get<ArgType::Format>();
	if (!IsEqual(format, L"json") && !IsEqual(format, L"table"))
	{
	throw CommandException(Localization::WSLCCLI_InvalidFormatError());
	}
	}
	UNREFERENCED_PARAMETER(execArgs);
	// Format validation is handled by the shared validation path used by ListVolumes.

[Copilot]

WideToMultiByte(volumeName) is recomputed on every iteration in both VerifyVolumeIsListed and VerifyVolumeIsNotListed. Convert once before the loop (e.g., auto needle = WideToMultiByte(volumeName);) and compare against that to avoid repeated allocations/conversions.