Open
Conversation
+this is what I carried over from older developments we did in another branch.
+open points to check further ;
--complete tests
--send this as a parameter to reports
--check menu items for themes
+ To simply any future modifications , all theme definitions will be managed from single place and will load the combobox dynamically +Initial Tests
…acitandogan_20251118_AccessibilityEnhancements_NewRound
worked on 4096,4041,4100
…d via various functionality when LogMessage() is used
…d' of https://github.com/microsoft/SqlNexus into hacitandogan_20251118_AccessibilityEnhancements_NewRound
…and that would cause a Null reference exception.
…struction report, but only if you hit Enter or Space bar
…ocus lands on "Instructions" control or when switching databases in the current DB control.
…k a database using a mouse click, the selection switches to a new database automatically (instead of requiring an Enter)
… original SQL Nexus colors #475 modifications to default theme to match left hand menu colors to original SQL Nexus colors
…eedback. #475 added missing accessibility name based on accessibility team's feedback after their tests.
#475 correcting the logic for leftMenu bool variable to set it to true at right place
• fmLoginEx.cs: Theme dropdown now refreshes the report immediately via BeginInvoke; Cancel reverts report theme; removed redundant refresh from FormClosing • fmNexus.cs: RefreshCurrentReportTheme and RefreshReport skip reports with unresolved parameters to prevent InvalidOperationException from async GetDocumentMap; new ReportViewer controls get ApplyTheme on creation so first-launch theming is correct • SQL Perf Main.rdl: Replaced hardcoded text colors (Black, DimGray, Blue) and FmtHyperLinkTextColor/FmtAmbientBackground parameter references with theme-aware report variables (ReportTextColor, TitleColor, TableHeadingFontColor, TableHeadingColor)
…d' of https://github.com/microsoft/SqlNexus into hacitandogan_20251118_AccessibilityEnhancements_NewRound
…ll through reports wasn't updating contrast them: SetReportQueryParameters() returned early for reports without dataset-bound parameters, skipping the ContrastTheme injection entirely during drillthrough navigation
…y updating ContrastTheme and re-rendering in tsbBack_Click, and removing overly strict null-parameter guards that silently blocked report refreshes
…can be debugged
…acitandogan_20251118_AccessibilityEnhancements_NewRound
…o box comes in the right tab sequence
Added option to ignore .rptproj files during build.
…o build this on Github Actions
… think about future implemention of this if needed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ULL exception in a function
…ats_C.rdl WASD_Deadlocks_C.rdl WaitDetails_C.rdl Reports
…ocking Detail_C.rdl SQL 2000 Blocking_C.rdl TopN_Resources_By_QDS_C.rdl reports
…r moves to different positions in the main application window) Restore the original Controls.Add order for toolbars in fmNexus.Designer.cs. WinForms ToolStripPanel lays out controls in reverse add order (last added = top row). The order was inadvertently changed on this branch, causing the main toolbar (SQL connect, folder, help buttons) to shift position depending on window width. Before (broken): toolbarMain, toolbarService, menuBarMain, toolbarReport After (restored): menuBarMain, toolbarService, toolbarReport, toolbarMain
…nd WASD_Connection_Stats reports Add ContrastTheme parameter, 11 theme variables, and wire all UI elements to theme variables for Aquatic/Desert/None contrast theme
Add ContrastTheme parameter, 11 theme variables, and wire all UI elements to theme variables for Aquatic/Desert/None contrast themes:
…dialog for Username and Psswrd WinForms disabled labels ignore ForeColor and render with a system-derived dark gray via ControlPaint.DrawStringDisabled(), which is invisible on Aquatic's dark #202020 background. Fix: Keep User Name and Password labels always Enabled=true and simulate the disabled appearance by setting a muted ForeColor: - Aquatic: #808080 (medium gray, visible on dark background) - Desert: #A0A0A0 (lighter gray, visible on warm background) - Default: SystemColors.GrayText (standard system disabled color) Also re-apply dimming in cmbTheme_SelectedIndexChanged after ThemeManager.ApplyTheme resets all control ForeColors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.