Handle float inputs by coercing to nearest integer range#24
Open
scovetta wants to merge 1 commit intomicromatch:masterfrom
Open
Handle float inputs by coercing to nearest integer range#24scovetta wants to merge 1 commit intomicromatch:masterfrom
scovetta wants to merge 1 commit intomicromatch:masterfrom
Conversation
Float arguments (e.g., toRegexRange(1.5, 9.5)) previously produced invalid regex output. Now floats are coerced to the tightest integer sub-range using ceil(min)/floor(max), and a RangeError is thrown when no integers exist within the given bounds (e.g., 1.2 to 1.8).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Float arguments (e.g.,
toRegexRange(1.5, 9.5)) previously produced invalid regex output. Now floats are coerced to the tightest integer sub-range usingceil(min)/floor(max), and aRangeErroris thrown when no integers exist within the given bounds (e.g., 1.2 to 1.8).Fixes #5