Repository navigation
Conversation
TuomasBorman
left a comment
Contributor
There was a problem hiding this comment.
It could be own function. Then you could have a flag in getWilcoxon to calculate also effect size.
By doing that, we could use it also elsewhere where needed.
TuomasBorman
requested changes
Apr 22, 2026
TuomasBorman
left a comment
Contributor
There was a problem hiding this comment.
Thanks, check sugestions
Contributor
|
Sorry the review was a bit messy. This was the idea: |
getEffectSize() calculates Cliff's delta or Cohen's d with effsize for each feature and pair of groups. getWilcoxonTest(effect.size = ) adds it to the test results. Replaces the earlier internal implementation, as suggested in review.
Contributor
Author
|
Reworked as you suggested: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
getEffectSize(), which calculates Cliff's delta or Cohen's d (effsize) for each feature and pair of groups, and aneffect.sizeoption togetWilcoxonTest()that adds it to the results. Not supported for paired tests.Closes #12