feat: Add rollback, lock file, strict mode, and security improvements#56
Open
ricanwarfare wants to merge 1 commit intomichealespinola:masterfrom
Open
feat: Add rollback, lock file, strict mode, and security improvements#56ricanwarfare wants to merge 1 commit intomichealespinola:masterfrom
ricanwarfare wants to merge 1 commit intomichealespinola:masterfrom
Conversation
New Features: - Added -r flag for rollback to previous installed version - Added -b flag to skip minimum age check - Added concurrent execution protection via lock file - Added set -euo pipefail for stricter error handling Improvements: - Better handling of stale lock files (checks if PID is still running) - Updated help text with new options - Added fork attribution in header Security: - Plex tokens are now masked in debug output (only last 4 chars visible) - Lock file prevents multiple simultaneous runs Version bumped to 4.8.0
Owner
|
These are some great additions and you've beat me to the punch on a couple of them. Kudos and thanks! A couple of features you have added here technically already exist or are code I have not added to the public repo yet:
It would be more ideal if individual PRs are made per major functionality change, and not all grouped together. These are my notes so far, and I'm still reviewing and testing your PR |
Author
|
Hey!
No worries. I been a big fan of your script so i thought to try to give
something back. I am gonna be honest, Im still learning the rules of how to
contribute properly in a PR and you are right, it should have been better
to break them down in parts for easy review and merging by you. I’ll take
notes for that next time. Im still learning the courtesies of git itself.
Again, I appreciate your work on this. I did miss the -a 0, I didnt read it as a way to just force an update. I
have it where task scheduler runs it so I mostly followed the readme. Let me know what you are planning to use and maybe i can retract the PR and just push the functions you only need.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds several quality-of-life improvements and security hardening to the syno.plexupdate script.
New Features
-rFlag: Rollback to Previous Version.spkfile in Archive/Packages-bFlag: Skip Age CheckConcurrent Execution Protection
/tmp/syno.plexupdate.lockSecurity Improvements
Token Masking
Strict Mode
set -euo pipefailfor stricter error handlingTesting
bash -nChangelog Entry
Maintained by @ricanwarfare as a fork of this excellent project.