add NRF54L15_DK HardwareModel enum value (132)#896
Closed
cvaldess wants to merge 1 commit intomeshtastic:masterfrom
Closed
add NRF54L15_DK HardwareModel enum value (132)#896cvaldess wants to merge 1 commit intomeshtastic:masterfrom
cvaldess wants to merge 1 commit intomeshtastic:masterfrom
Conversation
Reserves enum value 132 for the Nordic nRF54L15-DK community firmware port. The port is tracked in meshtastic/firmware#10193 and currently uses HardwareModel_PRIVATE_HW as a placeholder until this PR merges and the regenerated protobufs propagate back into the firmware tree. Board: Nordic nRF54L15-DK (PCA10156), Zephyr RTOS, external EBYTE E22-900M30S (SX1262) LoRa module. Firmware variant: nrf54l15dk.
6 tasks
Member
|
The DK is considered a DIY hardware and should remain under the PRIVATE_HW label. We're kinda running out of numbers here. (Existing DIY allocated numbers are grandfathered as they are not easily changed). If we have the first 'canon' device with nrf54 i'll galdly assign a number. Thanks for understanding. |
Author
|
i'm working on nrf54 device,it will work with our nrf54 port of meshtastic firmware (PR #10193) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reserves `HardwareModel` enum value 132 for the Nordic nRF54L15-DK community firmware port.
The port is tracked in meshtastic/firmware#10193 and currently uses `HardwareModel_PRIVATE_HW` as a placeholder; once this PR merges and the regenerated protobufs propagate back into the firmware tree, `HW_VENDOR` can be flipped to the proper `NRF54L15_DK` value.
Hardware
Change
One new enum entry added to `HardwareModel` in `meshtastic/mesh.proto`, slotting between the last THINKNODE ID (131) and the reserved `PRIVATE_HW` (255). No other files touched.
Test plan
🤖 Generated with Claude Code