Rotary encoder fixes

[80HD-0]

🤝 Attestations

• I have tested that my proposed changes behave as described.
• I have tested that my proposed changes do not cause any obvious regressions on the following devices:
  • Heltec (Lora32) V3
  • LilyGo T-Deck
  • LilyGo T-Beam
  • RAK WisBlock 4631
  • Seeed Studio T-1000E tracker card
  • Other (please specify below)

Note: I did not verify the other devices listed because I don't have all of them, but either way, none of them have a rotary encoder, which is the only component this PR is focused on fixing.

This PR fixes a bug with the rotary encoder where an incorrectly defined interrupt handler caused it to constantly fire button press events while the rotary encoder button was held down. By extension, this bypasses the debounce function already implemented. The debounce time was also decreased, since it was a bit long. This is probably due to someone else noticing this bug and trying to fix it by increasing the debounce.

Not only would this bug cause unwanted button presses (like an exit button in a menu reopening the menu instantly), it seemed to crash the device if it was held down longer than about a half second. With this fix, the debounce works as intended, preventing these unwanted presses and stopping the crash that would previously happen.

I have verified that on my Heltec V3, this does not break anything.

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}