BaseUI: Nodelist screen/favorite screen cleanup #10197
Merged
Conversation
Contributor
HarukiToreda
commented
Apr 18, 2026
HarukiToreda
commented
- Updated BaseUI Hops/Signal row to only render signal bars for direct neighbors (hops_away == 0), preventing relayed nodes from showing misleading signal quality.
- Replaced node-list hop text format from bracketed form ([2]) to count + hop icon (2 + hop glyph), matching Favorite view styling.
- Updated Favorite node details screen with the same zero-hop signal rule (signal text/bars only for hops_away == 0; non-zero hops still shown).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b89e752b20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Xaositek
approved these changes
Apr 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the BaseUI node list and favorite-node detail rendering to reduce misleading signal indicators and to standardize hop-count presentation across views.
Changes:
- Restricts signal quality text/bars to direct neighbors only (
hops_away == 0) in Favorite node details and the Node List hop/signal row. - Updates hop-count presentation to use a numeric count plus hop glyph (instead of bracketed hop text), aligning Node List styling with the Favorite view.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/graphics/draw/UIRenderer.cpp |
Updates Favorite node details to only show signal for zero-hop nodes and adjusts hop/signal line composition. |
src/graphics/draw/NodeListRenderer.cpp |
Updates Node List hop/signal entry to only show bars for zero-hop nodes and replaces hop text with count + hop icon. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
caveman99
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.