[meshery-cilium] ci: globally disable ST1005 staticcheck lint rule#197
Open
Devesanoff wants to merge 1 commit intomeshery-extensions:masterfrom
Open
[meshery-cilium] ci: globally disable ST1005 staticcheck lint rule#197Devesanoff wants to merge 1 commit intomeshery-extensions:masterfrom
Devesanoff wants to merge 1 commit intomeshery-extensions:masterfrom
Conversation
Signed-off-by: Devesanoff <esanovmadaminjon@gmail.com>
banana-three-join
suggested changes
Apr 29, 2026
| linters-settings: | ||
| staticcheck: | ||
| checks: ["all", "-ST1005"] | ||
| depguard: |
There was a problem hiding this comment.
depguard was added again when it's already present in the under this setting. needs to be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
staticcheckconfiguration to.golangci.ymlto globally and permanently disable the ST1005 (lowercase error strings) lint rule for the Cilium adapter.Fixes meshery/meshery#16867
Notes for Reviewers
staticchecksettings to.golangci.ymlto ignore ST1005.staticcheckwas already enabled in the linters list.Signed commits