-
Notifications
You must be signed in to change notification settings - Fork 38
fix: correct branding from 'kanvas.new' to 'Kanvas' and fix X/Twitter social preview #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Deepika-s04
wants to merge
7
commits into
meshery-extensions:master
Choose a base branch
from
Deepika-s04:fix/branding-kanvas-name-195
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
543032c
fix: correct branding from 'kanvas.new' to 'Kanvas'
Deepika-s04 64e726a
fix: use absolute URL for og:image and twitter:image
Deepika-s04 a8c99b3
fix: update twitter meta tags and og:image to use correct base URL
Deepika-s04 ab68dc8
fix: update twitter meta tags and og:image to use correct base URL
Deepika-s04 3e5daee
Merge branch 'master' into fix/branding-kanvas-name-195
Rajesh-Nagarajan-11 667a023
fix: correct og:image and twitter:image to use absolute URLs
Deepika-s04 50aff6d
Merge branch 'fix/branding-kanvas-name-195' of https://github.com/Dee…
Deepika-s04 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,44 @@ | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <link rel="apple-touch-icon" sizes="180x180" href="/favicons/apple-touch-icon.png"> | ||
| <link rel="icon" type="image/png" sizes="32x32" href="/favicons/favicon-32x32.png"> | ||
| <link rel="icon" type="image/png" sizes="16x16" href="/favicons/favicon-16x16.png"> | ||
| <link rel="manifest" href="/favicons/site.webmanifest"> | ||
| <link rel="mask-icon" href="/favicons/safari-pinned-tab.svg"> | ||
| <link rel="shortcut icon" href="/favicons/favicon.ico"> | ||
| <meta name="msapplication-TileColor" content="#da532c"> | ||
| <meta name="msapplication-config" content="/favicons/browserconfig.xml"> | ||
| <meta name="theme-color" content="#ffffff"> | ||
| <title>{{ if .IsHome }}{{ .Site.Title }}{{ else }}{{ .Title }} | {{ .Site.Title }}{{ end }}</title> | ||
|
|
||
| <meta name="description" content="{{ with .Description }}{{ . }}{{ else }}{{ .Site.Params.description }}{{ end }}"> | ||
| <meta property="og:title" content="{{ if .IsHome }}{{ .Site.Title }}{{ else }}{{ .Title }} | {{ .Site.Title }}{{ end }}" /> | ||
| <meta property="og:description" content="{{ with .Description }}{{ . }}{{ else }}{{ .Site.Params.description }}{{ end }}" /> | ||
| <meta property="og:type" content="website" /> | ||
| <meta property="og:url" content="{{ .Permalink }}" /> | ||
| <meta property="og:image" content="{{ printf "%s/brand/kanvas/stacked/kanvas-stacked-color.png" (site.Params.canonicalBaseURL | strings.TrimRight "/") }}" /> | ||
| <meta name="twitter:card" content="summary_large_image"> | ||
|
|
||
| <meta name="twitter:site" content="@mesheryio"> | ||
| <meta name="twitter:title" content="{{ if .IsHome }}{{ .Site.Title }}{{ else }}{{ .Title }} | {{ .Site.Title }}{{ end }}"> | ||
| <meta name="twitter:description" content="{{ with .Description }}{{ . }}{{ else }}{{ .Site.Params.description }}{{ end }}"> | ||
| <meta name="twitter:image" content="{{ printf "%s/brand/kanvas/stacked/kanvas-stacked-color.png" (site.Params.canonicalBaseURL | strings.TrimRight "/") }}" /> | ||
| {{- with site.Params.canonicalBaseURL }} | ||
| <link rel="canonical" href="{{ . | strings.TrimRight "/" }}{{ $.RelPermalink }}"> | ||
| {{- end }} | ||
| {{- if eq (getenv "HUGO_PREVIEW") "true" }} | ||
| <meta name="robots" content="noindex, nofollow"> | ||
| {{- end }} | ||
| <link rel="preconnect" href="https://fonts.googleapis.com"> | ||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
| <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet"> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.2/css/all.min.css" integrity="sha512-SnH5WK+bZxgPHs44uWIX+LLJAJ9/2PkPKZ5QiAj6Ta86w+fsb2TkcmfRyVX3pBnMFcV7oQPJkl9QevSCWr3W6A==" crossorigin="anonymous" referrerpolicy="no-referrer" /> | ||
| {{ partial "head-css.html" . }} | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
|
|
||
| <link rel="apple-touch-icon" sizes="180x180" href="/favicons/apple-touch-icon.png"> | ||
| <link rel="icon" type="image/png" sizes="32x32" href="/favicons/favicon-32x32.png"> | ||
| <link rel="icon" type="image/png" sizes="16x16" href="/favicons/favicon-16x16.png"> | ||
| <link rel="manifest" href="/favicons/site.webmanifest"> | ||
| <link rel="mask-icon" href="/favicons/safari-pinned-tab.svg"> | ||
| <link rel="shortcut icon" href="/favicons/favicon.ico"> | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ^^ |
||
| <meta name="msapplication-TileColor" content="#da532c"> | ||
| <meta name="msapplication-config" content="/favicons/browserconfig.xml"> | ||
| <meta name="theme-color" content="#ffffff"> | ||
|
|
||
| <title>{{ if .IsHome }}{{ .Site.Title }}{{ else }}{{ .Title }} | {{ .Site.Title }}{{ end }}</title> | ||
|
|
||
| <meta name="description" content="{{ with .Description }}{{ . }}{{ else }}{{ .Site.Params.description }}{{ end }}"> | ||
|
|
||
| <meta property="og:title" content="{{ if .IsHome }}{{ .Site.Title }}{{ else }}{{ .Title }} | {{ .Site.Title }}{{ end }}" /> | ||
| <meta property="og:description" content="{{ with .Description }}{{ . }}{{ else }}{{ .Site.Params.description }}{{ end }}" /> | ||
| <meta property="og:type" content="website" /> | ||
| <meta property="og:url" content="{{ .Permalink }}" /> | ||
| <meta property="og:image" content="https://www.kanvas.new/brand/kanvas/stacked/kanvas-stacked-color.png" /> | ||
|
|
||
| <meta name="twitter:card" content="summary_large_image"> | ||
| <meta name="twitter:title" content="{{ if .IsHome }}{{ .Site.Title }}{{ else }}{{ .Title }} | {{ .Site.Title }}{{ end }}"> | ||
| <meta name="twitter:description" content="{{ with .Description }}{{ . }}{{ else }}{{ .Site.Params.description }}{{ end }}"> | ||
| <meta name="twitter:image" content="https://www.kanvas.new/brand/kanvas/stacked/kanvas-stacked-color.png"> | ||
| <meta name="twitter:url" content="{{ .Permalink }}"> | ||
|
Comment on lines
+25
to
+29
|
||
|
|
||
| {{- with site.Params.canonicalBaseURL }} | ||
| <link rel="canonical" href="{{ . | strings.TrimRight "/" }}{{ $.RelPermalink }}"> | ||
|
Comment on lines
+19
to
+32
|
||
| {{- end }} | ||
|
|
||
| {{- if eq (getenv "HUGO_PREVIEW") "true" }} | ||
| <meta name="robots" content="noindex"> | ||
| {{- end }} | ||
|
|
||
| <link rel="preconnect" href="https://fonts.googleapis.com"> | ||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
| <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet"> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.2/css/all.min.css" integrity="sha512-SnH5WK+bZxgPHs44uWIX+LLJAJ9/2PkPKZ5QiAj6Ta86w+fsb2TkcmfRyVX3pBnMFcV7oQPJkl9QevSCWr3W6A==" crossorigin="anonymous" referrerpolicy="no-referrer" /> | ||
|
|
||
| {{ partial "head-css.html" . }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you added one more extra line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do this keep the changes mininal