Skip to content

feat: added a theme toggle button#175

Closed
ARZU-V wants to merge 2 commits intomeshery-extensions:masterfrom
ARZU-V:feat/theme-toggle-button
Closed

feat: added a theme toggle button#175
ARZU-V wants to merge 2 commits intomeshery-extensions:masterfrom
ARZU-V:feat/theme-toggle-button

Conversation

@ARZU-V
Copy link
Copy Markdown
Contributor

@ARZU-V ARZU-V commented Mar 21, 2026 •
edited
Loading

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 21, 2026 •
edited
Loading

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-04-29 17:42 UTC

Bhumikagarggg
Bhumikagarggg requested changes Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Bhumikagarggg Bhumikagarggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use same toggle font as https://meshery.io/ have and change place of toggle button it should be upside

@ARZU-V
Copy link
Copy Markdown
Contributor Author

ARZU-V commented Mar 21, 2026

Use same toggle font as https://meshery.io/ have and change place of toggle button it should be upside
I will make the changes but wouldnt the toggle button placed at top with Kanvas logo look weird ?

@Bhumikagarggg
Copy link
Copy Markdown
Contributor

Bhumikagarggg commented Mar 22, 2026 •
edited
Loading

@ARZU-V Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@ARZU-V
feat: added a theme toggle button
5a86ea2 
Signed-off-by: Arjit Verma <arjitverma73@gmail.com>
@ARZU-V ARZU-V force-pushed the feat/theme-toggle-button branch from ebec01d to 5a86ea2 Compare March 22, 2026 16:08
@ARZU-V ARZU-V requested a review from Bhumikagarggg March 22, 2026 16:25
leecalcote
leecalcote requested changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text color needs to contrast with background color.

Image

@ARZU-V
Copy link
Copy Markdown
Contributor Author

ARZU-V commented Mar 28, 2026

Text color needs to contrast with background color.

Image

On it 🫡

@Bhumikagarggg
Copy link
Copy Markdown
Contributor

Bhumikagarggg commented Apr 5, 2026

@ARZU-V Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@Bhumikagarggg
Copy link
Copy Markdown
Contributor

Bhumikagarggg commented Apr 19, 2026

@ARZU-V Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@Bhumikagarggg Bhumikagarggg added the issue/remind Issue progress check label Apr 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Bhumikagarggg
Copy link
Copy Markdown
Contributor

Bhumikagarggg commented Apr 29, 2026

No response? I'm closing this PR. Thanks @ARZU-V for efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leecalcote leecalcote leecalcote requested changes

@Bhumikagarggg Bhumikagarggg Awaiting requested review from Bhumikagarggg

Assignees

No one assigned

Labels

area/ui issue/remind Issue progress check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Light/Dark Mode Toggle Button

3 participants

@ARZU-V @Bhumikagarggg @leecalcote