fix(room_server): support RX boosted gain#3023
Merged
Merged
Conversation
The room server never supported RX boosted gain, while the repeater does. Three consequences on SX1262/SX1268 boards: - boosted gain was never applied to the radio at boot, so a room server ran in power-saving RX mode while an identical repeater ran boosted - a real receive-sensitivity difference with nothing pointing at it - _prefs.rx_boosted_gain was never initialised (the prefs are memset to 0 before defaults are set), so it defaulted to off - 'set radio.rxgain on' replied "Error: unsupported" but CommonCLI had already written the value to prefs and saved them, so a stale setting survived reboot and was never applied Mirror the repeater's implementation: initialise the pref default under the same USE_SX1262/USE_SX1268 and SX126X_RX_BOOSTED_GAIN guards, apply it during radio init, and override setRxBoostedGain() so the CLI reports success and takes effect. Built Heltec_v3_room_server (SX1262) and LilyGo_T3S3_sx1276_room_server (guards compile out cleanly).
hermes-gadget
added a commit
to gadgethd/MeshCore-MQTT
that referenced
this pull request
Jul 23, 2026
Upstream commits: - a71cc23 fix(room_server): support RX boosted gain - 8a69f34 Merge pull request meshcore-dev#3023 from agessaman/fix/rx-boosted-gain Clean auto-merge (no conflicts). MQTT additions preserved. Files changed: - examples/simple_room_server/MyMesh.cpp: 13 insertions - examples/simple_room_server/MyMesh.h: 1 insertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The room server exposes the shared
radio.rxgainpreference throughCommonCLI, but unlike the repeater, it does not connect that preference to the radio:rx_boosted_gainis not given the repeater’s default and remains zero after preference initializationset radio.rxgain onsaves the preference, but returnsError: unsupportedand does not apply it immediatelyThis mirrors the repeater implementation: initialize the default under the same radio guards, apply the preference during startup, and override
setRxBoostedGain()so CLI changes take effect.Built
Heltec_v3_room_server(SX1262) andLilyGo_T3S3_sx1276_room_server(unsupported-radio fallback).