Fix region command whitespace parsing#3016
Open
axhoff wants to merge 1 commit into
Open
Conversation
axhoff
marked this pull request as ready for review
July 21, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
regioncommands<null>Root cause
The generic text splitter preserves empty fields. For
region default, that produced an empty third argument.findByNamePrefix("")then matched the last region in the table, after which the default-region handler also cleared its deny-flood flag and persisted the change.Region commands now opt into a separately named splitter that ignores empty separator fields. Bare
region default, including trailing spaces, remains the documented read-only query. Clearing the default remains explicit:region default <null>.The original four-argument
Utils::parseTextPartssymbol and behavior are unchanged.Impact
Trailing or repeated spaces can no longer select a region accidentally, change its flood policy, or persist an unintended default scope.
Fixes #2992
Validation
pio test -e nativepio run -e RAK_4631_repeaterpio run -e Station_G2_repeatergit diff --check