Preserve UTF-8 boundaries in advert names#3004
Open
axhoff wants to merge 1 commit into
Open
Conversation
axhoff
marked this pull request as ready for review
July 20, 2026 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
AdvertDataBuilder::encodeTo()copied names until the raw byte budget was exhausted. Location data leaves 23 bytes for the name, so a 24-byte name could be cut inside a multi-byte code point and emitted as invalid UTF-8.Scope
The defensive check is at the final encoder, so it protects names saved by older firmware as well as current input paths. The packet layout and byte budgets are unchanged; only the valid prefix that fits is emitted.
Validation
git diff --checkpio test -e native— 17/17 tests passedpio run -e Heltec_v3_repeaterFixes #2613