feat(deviceauth): add feature flag to restore legacy provision behavior - #2134
Open
alfrunes wants to merge 3 commits into
Open
feat(deviceauth): add feature flag to restore legacy provision behavior#2134alfrunes wants to merge 3 commits into
alfrunes wants to merge 3 commits into
Conversation
70796e3 had a side effect of changing the iot-manager webhook events to no longer trigger provision_device event more than once. This commit introduces a feature flag to restore this legacy behavior. Ticket: MEN-10027 Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
mzedel
reviewed
Aug 4, 2026
mzedel
left a comment
mzedel
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the prompt adjustment! AFAICT the change looks good!
|
|
||
| if dev.Provisioned { | ||
| workflowName := "provision_device" | ||
| if d.config.LegacyProvisionEvent { |
Contributor
There was a problem hiding this comment.
since some tenants may rely on this but I guess very very not many and some may rely on the opposite, I would consider creating per-tenant flag (I know). I would also check perhaps somehow how many of the events we process on hosted -- perhaps it is not such a big deal.
Added feature flags []string to request context. The attribute is meaningless in open source, but is taken from the feature flags associated with the tenant. Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
70796e3 had a side effect of changing the iot-manager webhook events to no longer trigger provision_device event more than once. This commit introduces a feature flag to restore this legacy behavior.
Ticket: MEN-10027