chore(desktop): clean up stale settings navigation plumbing#682
Open
Fodesu wants to merge 1 commit into
Open
Conversation
Remove the legacy settings renderer entry and settings-specific navigation IPC. Native menu and tray actions now open settings through the shared renderer navigation channel instead of treating settings as a separate window. Update related desktop/web docs, tighten desktop settings route resolution, add missing reused route names, add Members and Keyboard tray entries, and cover renderer navigation with focused tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop already serves settings from the primary renderer. This PR removes stale leftovers from the older standalone settings renderer model and updates the remaining navigation/docs to match the current runtime.
renderer:navigatepath.Validation
mise exec -- pnpm --filter @memohai/desktop typecheckmise exec -- pnpm vitest run --project desktop