Skip to content

feat: Add log_retention_days as a configuration value #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
as51340 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add log_retention_days as a configuration value #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/memgraph-high-availability/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ livenessProbe:
- "--also-log-to-stderr"
{{- end }}
- "--log-file={{ $logging.log_file }}"
- "--log-retention-days={{ $logging.log_retention_days }}"
{{- end }}


Expand Down
3 changes: 3 additions & 0 deletions charts/memgraph-high-availability/templates/coordinators.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@ spec:
{{- if hasPrefix "--bolt-key-file" $arg }}
{{- fail (printf "Do not set --bolt-key-file in coordinators[id=%s].args; enable coordinators[id=%s].tls.bolt instead (auto-appended)." $coordinator.id $coordinator.id) }}
{{- end }}
{{- if hasPrefix "--log-retention-days" $arg }}
{{- fail (printf "Do not set --log-retention-days in coordinators[id=%s].args; configure commonArgs.coordinators.logging.log_retention_days instead." $coordinator.id) }}
{{- end }}
{{- end }}
{{- if and $coordinator.tls.bolt.enabled (not $coordinator.tls.bolt.secretName) }}
{{- fail (printf "coordinators[id=%s].tls.bolt.enabled is true but secretName is empty." $coordinator.id) }}
Expand Down
3 changes: 3 additions & 0 deletions charts/memgraph-high-availability/templates/data.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@ spec:
{{- if hasPrefix "--bolt-key-file" $arg }}
{{- fail (printf "Do not set --bolt-key-file in data[id=%s].args; enable data[id=%s].tls.bolt instead (auto-appended)." $data.id $data.id) }}
{{- end }}
{{- if hasPrefix "--log-retention-days" $arg }}
{{- fail (printf "Do not set --log-retention-days in data[id=%s].args; configure commonArgs.data.logging.log_retention_days instead." $data.id) }}
{{- end }}
{{- end }}
{{- if and $data.tls.bolt.enabled (not $data.tls.bolt.secretName) }}
{{- fail (printf "data[id=%s].tls.bolt.enabled is true but secretName is empty." $data.id) }}
Expand Down
2 changes: 2 additions & 0 deletions charts/memgraph-high-availability/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,11 +361,13 @@ commonArgs:
log_level: "TRACE" # Must not be empty.
also_log_to_stderr: true # Can only be bool
log_file: "/var/log/memgraph/memgraph.log" # If empty, log file won't be created
log_retention_days: 35 # For how many days should logs get persisted
coordinators: # Common args for coordinator instances
logging:
log_level: "TRACE" # Must not be empty.
also_log_to_stderr: true # Can only be bool
log_file: "/var/log/memgraph/memgraph.log" # If empty, log file won't be created
log_retention_days: 35

# If setting the --memory-limit flag under data instances, check that the amount of resources that a pod has been given is more than the actual memory limit you give to Memgraph
# Setting the Memgraph's memory limit to more than the available resources can trigger pod eviction and restarts before Memgraph can make a query exception and continue running
Expand Down
Loading