Skip to content
This repository was archived by the owner on Jan 11, 2022. It is now read-only.

Added Python Package#9

Open
vaibhavsingh97 wants to merge 1 commit intomeetmangukiya:masterfrom
vaibhavsingh97:Patch/python-package
Open

Added Python Package#9
vaibhavsingh97 wants to merge 1 commit intomeetmangukiya:masterfrom
vaibhavsingh97:Patch/python-package

Conversation

@vaibhavsingh97
Copy link
Copy Markdown

@vaibhavsingh97 vaibhavsingh97 commented Jun 26, 2018

Do-not-merge: Need Testing and also have to modify where all file downloads


__name__ = "Instagram Scraper"
__author__ = "Meet Mangukiya <meetmangukiya98@gmail.com>"
__version__ = '1.0.0'
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a stable API yet, 0.1.0 please.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import scrape_instagram_tag, and scrape_instagram here... from instagram_scraper.instagram_scraper import ... is too long.

Comment thread setup.py
),
entry_points={
'console_scripts': [
'scrape-insta = instagram_scraper.instagram_scraper:run',
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer scrape-instagram

@@ -0,0 +1,5 @@
from .instagram_scraper import main
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need main here?

@meetmangukiya
Copy link
Copy Markdown
Owner

@vaibhavsingh97 did a small review, thanks for the PR!
Regarding setting the paths, let's add a new argument --data-dir, -D which defaults to os.path.join(os.getcwd(), 'data')

@vaibhavsingh97
Copy link
Copy Markdown
Author

@meetmangukiya Sorry for keep you waiting this much longer. I will update this PR asap 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants