Clarify allowed binary types for serverCertificateHashes#44026
Open
mohammed-ali-osman wants to merge 2 commits intomdn:mainfrom
Open
Clarify allowed binary types for serverCertificateHashes#44026mohammed-ali-osman wants to merge 2 commits intomdn:mainfrom
mohammed-ali-osman wants to merge 2 commits intomdn:mainfrom
Conversation
mohammed-ali-osman
requested review from
chrisdavidmills
and removed request for
a team
github-actions
Bot
added
Content:WebAPI
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-05-06 17:18:48) |
mohammed-ali-osman
force-pushed
the
fix/webtransport-server-cert-hash-docs
branch
from
f04702f to
e177370
Compare
Contributor
Author
|
The GitHub Action PR Reviewdog failed twice to report and display linting issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update improves the documentation for
WebTransport()constructor, specifically clarifying the allowed types for theserverCertificateHashes.valuefield.The previous wording suggested only
ArrayBufferorTypedArrayin Syntax section, which was incomplete relative to theWebIDLspecification. The updated text now correctly reflects that the value can be anyBufferSource, including:ArrayBufferUint8Array)DataViewAdditionally, the example has been updated to clearly show the conversion from a hexadecimal SHA-256 hash string to its byte representation, improving clarity for developers.
Changes
serverCertificateHashes.valuetype description to include DataViewBufferSource(ArrayBuffer|ArrayBufferView)Fixes #44004