boot: bootutil: Change assert() calls to ASSERT()

[nordicjm]

MCUboot has an assert handler macro which is used from the simulator, align usage of assert calls to match it

[d3zd3z]

One problem with assert is that it can be compiled out. For security, that can really never be the case. Does ASSERT have this property? Otherwise, looks good.

[nordicjm]

One problem with assert is that it can be compiled out. For security, that can really never be the case. Does ASSERT have this property? Otherwise, looks good.

It's a macro you defined :) so there is this for all targets:

mcuboot/boot/bootutil/include/bootutil/bootutil_public.h

Line 145 in 74f4d64

#define ASSERT assert

which does also allow using a custom assert, and the simulator uses this:

mcuboot/sim/mcuboot-sys/csupport/mcuboot_config/mcuboot_assert.h

Line 25 in 74f4d64

void sim_assert(int, const char *test, const char *, unsigned int, const char *);

which is important for the simulator as it needs to be able to catch asserts for some tests rather than the rust executable dying at that point due to the assert() call, so for simulator this fixes this, for all other platforms there is no difference at all (unless they want a custom assert handler, in which case this would fix that also)