do not run i/o when precompiling#185
Conversation
|
Thanks for the PR. This issue has been fixed in the dev branch (which will become v2.0), but a version bump in v1 is a good idea. I'll need to take a look at the test failures, but I'll try to get this done soon. |
|
Would it be possible to release a fix quickly for This is currently deadlocking CI (as in https://github.com/JuliaPlots/Plots.jl/actions/runs/8514690332/job/23320875036?pr=4914#step:9:667). Thanks. |
|
I understand the urgency. I'll fix this and release ASAP. |
|
v1.1.1 has been released. Let me know if any issues come up. |
|
@mbaz, thanks, but the proposed fix doesn't work in Line 94 in c7fe06a The recommended way is to use |
|
Sorry about that. What version of Julia did you use to test? I tested on v1.6 and 1.10 and I don't see that message. Anyway, I have a more radical solution that should definitely solve this. I'll need a couple of days to implement it and cut a new release. |
|
This is on linux, julia |
|
Interesting; I'm on Linux and 1.10.2 myself. Is it possible for you to test using a branch (or a tag) on this repo, or do you need a release? |
|
We would need a new release since this is affecting CI: see for example https://github.com/JuliaPlots/Plots.jl/actions/runs/8514690332/job/23320875036?pr=4914#step:9:667 where |
|
And locally, |
|
v1.1.2 has been released -- please let me know how it goes. |
|
Thanks, it works, CI seems to go past precompilation now ... |
Fix issue when precompiling extensions:
A version bump would be appreciated.
Needed for JuliaPlots/Plots.jl#4904.