tests: fix makePairs job count regression from #1175 - #1177
Open
adRn-s wants to merge 1 commit into
Open
Conversation
The bwa_mapping fix in #1175 removed the redundant fastp jobs that used to run alongside the configured trimmer, so test_default's expected count should have gone back down to 176 (its pre-#1175 value), not stayed at 185, which was only correct for the broken intermediate state where both trimmers ran. CI on develop confirms the actual count is 176.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_default's expected job count was set to 185 in #1175, correct only for the intermediate broken state where both trimmers ran becausebwa_mappingignored thetrimmersetting. The same PR also fixed that bug, which removed the redundant fastp jobs and dropped the real count back to 176, its value before #1175. CI on develop has been failing since the merge because the test was never updated for this side effect.Changes
tests/test_jobcounts.py:TestmakePairs::test_defaultexpected job count, 185 → 176Test plan