Skip to content

Fly View: add altitude support for Click to ROI#14438

Open
Daksh7112003 wants to merge 1 commit into
mavlink:masterfrom
Daksh7112003:fix-roi-altitude
Open

Fly View: add altitude support for Click to ROI#14438
Daksh7112003 wants to merge 1 commit into
mavlink:masterfrom
Daksh7112003:fix-roi-altitude

Conversation

@Daksh7112003
Copy link
Copy Markdown

Description

Adds altitude support for Fly View "Click to ROI".

Previously, ROI commands only sent latitude and longitude coordinates,
causing the altitude field to remain unset/zero. This update includes
altitude in the ROI coordinate sent through MAVLink.

This improves camera/gimbal targeting accuracy when using Click to ROI.

Fixes #14394.

Type of Change

  • New feature (non-breaking change that adds functionality)

Testing

  • Tested locally
  • Tested with simulator (SITL)

Platforms Tested

  • Windows

Flight Stacks Tested

  • ArduPilot

Screenshots

N/A

Checklist

  • I have read the Contribution Guidelines
  • I have read the Code of Conduct
  • My code follows the project's coding standards

Related Issues

#14394

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your first pull request! 🎉

A maintainer will review this soon. Please ensure:

  • CI checks pass
  • Code follows coding standards
  • Changes tested on relevant platforms

We appreciate your contribution to QGroundControl!

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.55%. Comparing base (f29efd3) to head (117c834).
⚠️ Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
src/Vehicle/TerrainQueryCoordinator.cc 0.00% 8 Missing ⚠️
src/Vehicle/Vehicle.cc 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (26.55%) is below the target coverage (30.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14438      +/-   ##
==========================================
+ Coverage   25.47%   26.55%   +1.08%     
==========================================
  Files         769      767       -2     
  Lines       65912    66291     +379     
  Branches    30495    30669     +174     
==========================================
+ Hits        16788    17605     +817     
+ Misses      37285    36190    -1095     
- Partials    11839    12496     +657     
Flag Coverage Δ
unittests 26.55% <0.00%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Vehicle/TerrainQueryCoordinator.h 0.00% <ø> (ø)
src/Vehicle/Vehicle.cc 21.18% <0.00%> (-0.22%) ⬇️
src/Vehicle/TerrainQueryCoordinator.cc 8.40% <0.00%> (-0.45%) ⬇️

... and 125 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0425145...117c834. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 2 passed, 42 failed, 7 skipped.

Test Results

linux-coverage: 88 passed, 0 skipped
Total: 88 passed, 0 skipped

Code Coverage

Coverage Baseline Change
60.5% 60.4% +0.1%

Artifact Sizes

Artifact Size Δ from master
QGroundControl 216.77 MB -4.61 MB (decrease)
QGroundControl-aarch64 176.65 MB No change
QGroundControl-installer-AMD64 134.68 MB +0.00 MB (increase)
QGroundControl-installer-AMD64-ARM64 77.48 MB -0.01 MB (decrease)
QGroundControl-installer-ARM64 106.03 MB +0.01 MB (increase)
QGroundControl-linux 186.86 MB -147.82 MB (decrease)
QGroundControl-mac 186.86 MB No change
QGroundControl-windows 186.87 MB No change
QGroundControl-x86_64 172.32 MB +0.00 MB (increase)
Total size decreased by 152.44 MB

Updated: 2026-05-27 13:34:46 UTC • Triggered by: Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fly View: Click to ROI should support altitude

1 participant