fix(rid): Fix Remote ID indicator QML state handling#14434
Conversation
|
Thanks for your first pull request! 🎉 A maintainer will review this soon. Please ensure:
We appreciate your contribution to QGroundControl! |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (26.46%) is below the target coverage (30.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #14434 +/- ##
==========================================
+ Coverage 25.47% 26.46% +0.99%
==========================================
Files 769 767 -2
Lines 65912 66285 +373
Branches 30495 30667 +172
==========================================
+ Hits 16788 17542 +754
+ Misses 37285 36286 -999
- Partials 11839 12457 +618
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 2 passed, 42 failed, 7 skipped. Test Resultslinux-coverage: 88 passed, 0 skipped Code Coverage
Artifact Sizes
Updated: 2026-05-24 20:38:54 UTC • Triggered by: Linux |
Description
Addresses items 1-13 from #14220 for the Remote ID toolbar indicator and expanded indicator page.
This PR fixes QML runtime issues and cleanup findings, including:
remoteIDManageraccess when there is no active vehicleremoteIDStateupdate reactively when Remote ID flags or settings changeremoteIDManageraccess in the expanded indicator pageRemoteIDSettingsenum values instead of duplicated local enumsbasicIDFlagIgetypobreakstatements afterreturnConnectionshandler to Qt6 function syntaxItem 14 from #14220 is intentionally left out because moving region-change side effects from QML into C++ is a broader behavior change and should be handled separately.
Type of Change
Testing
Platforms Tested
Flight Stacks Tested
Screenshots
Not applicable.
Checklist
Related Issues
Addresses items 1-13 of #14220
By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).