Skip to content

fix(rid): Fix Remote ID indicator QML state handling#14434

Open
msli-dev wants to merge 1 commit into
mavlink:masterfrom
msli-dev:fix/remote-id-indicator-qml
Open

fix(rid): Fix Remote ID indicator QML state handling#14434
msli-dev wants to merge 1 commit into
mavlink:masterfrom
msli-dev:fix/remote-id-indicator-qml

Conversation

@msli-dev
Copy link
Copy Markdown

Description

Addresses items 1-13 from #14220 for the Remote ID toolbar indicator and expanded indicator page.

This PR fixes QML runtime issues and cleanup findings, including:

  • Guarding remoteIDManager access when there is no active vehicle
  • Making remoteIDState update reactively when Remote ID flags or settings change
  • Fixing undefined remoteIDManager access in the expanded indicator page
  • Using RemoteIDSettings enum values instead of duplicated local enums
  • Fixing the basicIDFlagIge typo
  • Removing unreachable break statements after return
  • Replacing emergency button source-string comparisons with boolean highlight state
  • Updating the Connections handler to Qt6 function syntax

Item 14 from #14220 is intentionally left out because moving region-change side effects from QML into C++ is a broader behavior change and should be handled separately.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/Build changes
  • Other

Testing

  • Tested locally
  • Added/updated unit tests
  • Tested with simulator (SITL)
  • Tested with hardware

Platforms Tested

  • Linux
  • Windows
  • macOS
  • Android
  • iOS

Flight Stacks Tested

  • PX4
  • ArduPilot

Screenshots

Not applicable.

Checklist

  • I have read the Contribution Guidelines
  • I have read the Code of Conduct
  • My code follows the project's coding standards
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally

Related Issues

Addresses items 1-13 of #14220


By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your first pull request! 🎉

A maintainer will review this soon. Please ensure:

  • CI checks pass
  • Code follows coding standards
  • Changes tested on relevant platforms

We appreciate your contribution to QGroundControl!

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.46%. Comparing base (f29efd3) to head (2e737fb).
⚠️ Report is 32 commits behind head on master.

❌ Your project check has failed because the head coverage (26.46%) is below the target coverage (30.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14434      +/-   ##
==========================================
+ Coverage   25.47%   26.46%   +0.99%     
==========================================
  Files         769      767       -2     
  Lines       65912    66285     +373     
  Branches    30495    30667     +172     
==========================================
+ Hits        16788    17542     +754     
+ Misses      37285    36286     -999     
- Partials    11839    12457     +618     
Flag Coverage Δ
unittests 26.46% <ø> (+0.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 132 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0425145...2e737fb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 2 passed, 42 failed, 7 skipped.

Test Results

linux-coverage: 88 passed, 0 skipped
Total: 88 passed, 0 skipped

Code Coverage

Coverage Baseline Change
60.4% 60.4% +0.0%

Artifact Sizes

Artifact Size Δ from master
QGroundControl 216.77 MB -4.61 MB (decrease)
QGroundControl-aarch64 176.67 MB +0.00 MB (increase)
QGroundControl-installer-AMD64 134.67 MB -0.02 MB (decrease)
QGroundControl-installer-AMD64-ARM64 77.50 MB +0.01 MB (increase)
QGroundControl-installer-ARM64 106.01 MB -0.02 MB (decrease)
QGroundControl-linux 186.86 MB -147.82 MB (decrease)
QGroundControl-mac 186.86 MB No change
QGroundControl-windows 186.87 MB No change
QGroundControl-x86_64 172.32 MB +0.01 MB (increase)
Total size decreased by 152.45 MB

Updated: 2026-05-24 20:38:54 UTC • Triggered by: Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant