add aliases to bytevector procedures for r7rs compat#650
Merged
mattwparas merged 5 commits intomattwparas:masterfrom May 5, 2026
Merged
add aliases to bytevector procedures for r7rs compat#650mattwparas merged 5 commits intomattwparas:masterfrom
mattwparas merged 5 commits intomattwparas:masterfrom
Conversation
similar to the read-bytes-into-buf procedure, but with start and end parameters and not just a length.
this simplifies the rust side a little but, but it also fixes an outstanding bug, where read-bytes-into-buf would just ignore the given amt and always try to fill the entire buf: ``` $ steel λ > (define port (open-input-string "test")) λ > (define buf (make-bytes 4)) λ > (read-bytes-into-buf buf 2 port) => 4 λ > buf => #u8(#x74 #x65 #x73 #x74) λ > (peek-char port) => (eof) λ > ```
mattwparas
approved these changes
May 5, 2026
Owner
|
thank you! sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and also add an alias for
bytes-copyforbytevector-copyfor consistency.additionally implement
bytes-read!(with abytevector-read!alias) and actually respect the parameter forread-bytes-into-bufby just implenting that via thebytes-read!procedure.