Skip to content

test(bvt): add WEEK and YEARWEEK function test cases#24295

Open
Ariznawlll wants to merge 9 commits intomatrixorigin:3.0-devfrom
Ariznawlll:add-week-yearweek-bvt-cases
Open

test(bvt): add WEEK and YEARWEEK function test cases#24295
Ariznawlll wants to merge 9 commits intomatrixorigin:3.0-devfrom
Ariznawlll:add-week-yearweek-bvt-cases

Conversation

@Ariznawlll
Copy link
Copy Markdown
Contributor

@Ariznawlll Ariznawlll commented May 7, 2026

Summary

Test plan

  • func_datetime_week.test — 93 cases, 100% pass via mo-tester
  • func_datetime_yearweek.test — 91 cases, 100% pass via mo-tester
  • func_datetime_interval_arithmetic.test — 58 cases, 100% pass via mo-tester
  • All results verified against MySQL for correctness

Related: #24236, #24234, #24235, #24293

🤖 Generated with Claude Code

, matrixorigin#24234)

Add comprehensive BVT cases for WEEK(date, mode) and YEARWEEK(date, mode)
to verify MySQL compatibility after the functions were implemented.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Ariznawlll Ariznawlll requested a review from heni02 as a code owner May 7, 2026 04:37
@qodo-code-review
Copy link
Copy Markdown

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 7, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Ariznawlll
Ariznawl@163.com


Ariznawl@163.com seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

…n#24235)

Add BVT cases for arithmetic expressions inside INTERVAL clause,
including modulo, addition, multiplication, and the NL2SQL week
calculation pattern: INTERVAL (DAYOFWEEK(date)+5)%7 DAY.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…#24298 matrixorigin#24299 fixes

- Remove @Label:bvt tags (verified, not marking as BVT)
- Regenerate result files against 3.0-dev @ f9f1981
- Update WEEK single-arg result (now respects default_week_format)
- Update INTERVAL arithmetic results (parenthesized expr fixed)
- Update YEARWEEK result for NULL mode

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The yearweek.test was rewritten but result file was stale (from old
test content), causing CI to mark all 91 cases as abnormal.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes [500,999] lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants