This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Proof of concept for MSC3613: Combinatorial join rules#11668
Closed
Proof of concept for MSC3613: Combinatorial join rules#11668
Conversation
MSC: matrix-org/matrix-spec-proposals#3613 This is not a comprehensive implementation and was only built to prove that the idea works in a limited test case (knocking+restricted). The following still need to be considered/completed: * [ ] Make code quality on par with the rest of the project * [ ] Tests * [ ] Use the utility function in all the places * [ ] Update redaction algorithm * [ ] Remove auth rule changes (see MSC) * [ ] Fix handling of `allow` (see TODOs in code)
turt2live
added
the
Z-Help-Wanted
Member
Author
|
MSC rejected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSC: matrix-org/matrix-spec-proposals#3613
This was originally built to prove the concept, and is contained in an unstable room version to help test it. The goal is to get this landed so people in the wild can experiment with it (and build clients against it).
The code quality of this PR is potentially incorrect - I'm hoping code review will cover anything which isn't great. As a not-python developer, I'm not going to be too hurt to hear that it's ugly ;)
TODO:
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)