Skip to content
Open
Changes from 37 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
6adc165
MSC4155: Invite filtering
Johennes Jun 13, 2024
43aef70
Fix typo
Johennes Jun 13, 2024
b8b226a
Update proposal with feedback from pull request
Johennes May 27, 2025
dcde420
Update proposals/4155-invite-filtering.md
Johennes May 30, 2025
04169f8
Update proposals/4155-invite-filtering.md
Johennes May 30, 2025
8c81fd5
Update proposals/4155-invite-filtering.md
Johennes May 30, 2025
d132a13
Update proposals/4155-invite-filtering.md
Johennes May 30, 2025
2345a5b
Update proposals/4155-invite-filtering.md
Johennes May 30, 2025
a558adb
Update proposals/4155-invite-filtering.md
Johennes May 30, 2025
a47dbce
Update proposals/4155-invite-filtering.md
Johennes May 30, 2025
e9478f0
Update proposals/4155-invite-filtering.md
Johennes Jun 2, 2025
29324e9
Drop capability and enforce the config on the server only
Johennes Jun 4, 2025
2f17aa7
Add missing client-side review option as a potential issue
Johennes Jun 4, 2025
3b248c5
Update proposals/4155-invite-filtering.md
Johennes Jun 5, 2025
230ed37
Update proposals/4155-invite-filtering.md
Johennes Jun 5, 2025
f916f98
Update proposals/4155-invite-filtering.md
Johennes Jun 5, 2025
44ecf7e
Update proposals/4155-invite-filtering.md
Johennes Jun 5, 2025
88fe9cc
Fix list indentation
Johennes Jun 26, 2025
be64f07
Extend alternatives
Johennes Jun 26, 2025
e526862
Update proposals/4155-invite-filtering.md
Johennes Jun 26, 2025
52c8bd5
Clarify interaction with m.ignored_user_list
Johennes Jun 30, 2025
0eee397
Fix typo
Johennes Jun 30, 2025
21521f0
Spell out what the globs should operate on
Johennes Jun 30, 2025
643c5bc
Avoid 'eponymous'
Johennes Jul 8, 2025
5c3cab8
Avoid over-specifying null / missing behaviour
Johennes Jul 8, 2025
16dd841
Update proposals/4155-invite-filtering.md
Johennes Jul 8, 2025
e735ee8
Add expanding m.ignored_user_list as an alternative
Johennes Jul 8, 2025
f65b9b2
Ignore ports when applying server globs
Johennes Jul 9, 2025
8c30b56
Add enabled property
Johennes Sep 9, 2025
eb06849
Add potential issue about unanticipated side effects of changes
Johennes Sep 9, 2025
f17d2ee
Clarify how to valide array properties
Johennes Oct 31, 2025
195199e
Use normative MUST
Johennes Nov 5, 2025
8d87122
Clarify that ignored invites can be unignored
Johennes Nov 5, 2025
64128c5
Remove dead link
Johennes Nov 5, 2025
e36e71d
Use normative wording
Johennes Nov 5, 2025
6fada45
Fix comma error / wordsmith
Johennes Nov 5, 2025
8ed8f33
Fix typo
Johennes Nov 5, 2025
31bbbb6
Add unstable_features flag
Johennes Nov 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
223 changes: 223 additions & 0 deletions proposals/4155-invite-filtering.md
Copy link
Copy Markdown
Member

@turt2live turt2live Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:

  • Client supporting the feature, and using it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I believe all the gematik implementations will be closed source, I'll reference #3860 (comment) as an example for how cases like this were handled in the past. Thanks @clokep for digging it up.

Copy link
Copy Markdown
Contributor

@Half-Shot Half-Shot Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

element-hq/synapse#18288 is a serverside implementation, albeit with #4155 (comment) "corrected"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

element-hq/element-web#29603 exposes the serverside settings in the client, but does no filtering of itself. @Johennes does this evoke any worries from you if the invite filtering is done server-side?

Copy link
Copy Markdown
Contributor Author

@Johennes Johennes Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I this is fine and consistent with the proposal which allows but doesn't enforce the filtering on either the client or the server. Now that I think of it, we might need a capability so that the client knows when the server does not filter in which case the client needs to filter itself.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I believe all the gematik implementations will be closed source,

Since it sounds like the biggest concern is whether a reasonable UI can be implemented, maybe a screenshot would suffice?

The gematik implementations are based on the initial version of this proposal where we had a base setting of either "allow all" or "block all" and exceptions for users and servers applied on top of it. It also didn't include any globbing.

FWIW, this is how my own health insurance has implemented it:

Main screen with radio buttons for the base setting at the top ("Alle" = "(Allow) everyone" / "Niemand" = "(Allow) noone"). Below that are two buttons to add exceptions for users ("Benutzer") and servers.

1

For adding user exceptions, they pop up a bottom sheet with a few options ("Teilnehmende hinzufügen"). The first two are for obtaining the MXID by searching gematik-specific directories. The third option scans the MXID from a QR code. And the last one lets you input it manually.

2 4

For server exceptions, the only option is to enter the server name manually.

5

Once entered, the exceptions show in a list at the bottom of the main screen.

6

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Johennes, that's extremely helpful. I'm concerned, however, that it only (appears to) offer controls for blocked_users and blocked_servers (i.e, it does not expose allowed_users, ignored_users, allowed_servers or ignored_servers), and nor does it expose globbing.

It is the interplay between these settings that I think makes this proposal complicated to implement in a client, and my concern remains that we don't yet have a viable client implementation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] it only (appears to) offer controls for blocked_users and blocked_servers (i.e, it does not expose allowed_users, ignored_users, allowed_servers or ignored_servers), and nor does it expose globbing.

Yes, the gematik implementations are based on the initial version of this MSC which used the following scheme:

{
  "type": "m.invite_permission_config",
  "content": {
    "default": "allow | block",
    "user_exceptions": {
      "@someone:example.org": {},
      ...
    },
    "server_exceptions": {
      "example.org": {},
      ...
    }
  }
}

I think the only apparent UX problem this has is that when you flip default, your previous exceptions suddenly apply the other way around.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose a client can help manage that UX problem by clearing user_exceptions and server_exceptions at the same time as changing default? That doesn't feel too bad to me, tbh.

(I'm sorry you've been sent so far around the houses on this, @Johennes. For now I'm going to focus on landing something in the spec, and then we can come back here and see if we can figure out a plausible way forward.)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries at all. 👍

Original file line number Diff line number Diff line change
@@ -0,0 +1,223 @@
# MSC4155: Invite filtering

Matrix supports ignoring users via the ["Ignoring Users" module] and the `m.ignored_user_list` account data
event. This is a nuclear option though and will suppress both invites and room events from the ignored
users. Additionally, the `m.ignored_user_list` event only allows for block-list configurations that ignore
specific users but doesn't have a mechanism to ignore entire servers. These shortcomings make the module
Comment thread
Johennes marked this conversation as resolved.
insufficient for use cases such as tightly locked down applications where ignoring needs to be the default
behaviour.

This proposal generalises the ignoring users module to allow filtering invites specifically. The scheme
outlined below was conceptually borrowed from the [gematik specification].


## Proposal

To allow users to configure which other users are allowed to invite them into rooms, a new account data
event `m.invite_permission_config` is introduced.

```json5
{
"type": "m.invite_permission_config",
"content": {
// Global on/off toggle
"enabled": true,
// User-level settings
"allowed_users": [ "@john:goodguys.org", ... ],
"ignored_users": [ ... ],
"blocked_users": [ ... ],
// Server-level settings
Comment thread
turt2live marked this conversation as resolved.
"allowed_servers": [ ... ],
"ignored_servers": [ ... ],
"blocked_servers": [ "*" ] // A feature of all the fields at this level, globs
}
Comment thread
Johennes marked this conversation as resolved.
}
```

`enabled` is a boolean property and defaults to `true` if omitted. It provides clients with a convenience on/off
toggle that lets them deactivate the configuration without purging it.
Comment on lines +37 to +38
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, enabled does not exist in the sample implementation in synapse

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this maybe needs more clarification as to what exactly "deactivate the configuration" means.

After discussion, and reading the associated thread, it seems like the intention is that enabled: false should block all invites. (i.e. it is equivalent to blocked_users: *, but at higher priority than allowed_users)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also (h/t @clokep here), could we have a more descriptive name? block_all, maybe?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I had interpreted it exactly the opposite way. This is why the proposal text says

If enabled is false, stop processing and allow.`

Upon re-reading the thread, I think your interpretation is correct though. 🤦‍♂️

Putting this into perspective with your concern about the UI in clients, I wonder if we should drop enabled as well given that you can do the same thing with blocked_users: *? The only downside is that you have to empty your allowed_users setting at the same time. We may be able to avoid this if we switched to the processing order used in server ACLs (as suggested in #4155 (comment)). I think you could just temporarily prepend * to your blocked_users then without touching the rest of your configuration.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Half-Shot, @turt2live: as those arguing for enabled: false to be a high-level "block all invites": can you weigh in on this please?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming back to this months later, I think the block_all was intended for clients who didn't support the full filtering spec to still have a block/unblock toggle in settings.

Element Web at the moment implements this by adding * to blocked_users (https://github.com/element-hq/element-web/blob/develop/src/settings/controllers/InviteRulesConfigController.ts#L77). I'm unconvinced that block_all is necessary.


All other properties in `content` are optional arrays. A missing property MUST be treated like an empty array.
Any value that is not an array of strings MUST lead to the entire event being considered invalid.

The array elements are [glob expressions]. Any `*_users` glob is to be matched against full user IDs (localpart
Comment thread
richvdh marked this conversation as resolved.
and domain). Any `*_servers` glob is to be matched against server names / domain parts of user IDs after
stripping any port suffix. This matches the way the globs from [server ACLs] are applied.
Comment on lines +44 to +45
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not match the current implementation in Synapse, which matches the entire domain.


When evaluating an invite, implementations MUST first apply the existing `m.ignored_user_list` as per
the current spec. If the invite didn't match, implementations MUST then apply `m.invite_permission_config`.
The complete processing logic is as follows:

1. Verify the invite against `m.ignored_user_list`:
1. If it matches `ignored_users`, stop processing and ignore.
2. Verify the invite against `m.invite_permission_config`:
1. If `enabled` is `false`, stop processing and allow.
2. If it matches `allowed_users`, stop processing and allow.
3. If it matches `ignored_users`, stop processing and ignore.
4. If it matches `blocked_users`, stop processing and block.
5. If it matches `allowed_servers`, stop processing and allow.
6. If it matches `ignored_servers`, stop processing and ignore.
7. If it matches `blocked_servers`, stop processing and block.
3. Otherwise, allow.

The semantics of "ignore" and "block" follow [MSC4283] which means ignoring hides the invite with no
feedback to the inviter whereas blocking rejects (or refuses, in the case of servers) the invite.
Comment thread
Johennes marked this conversation as resolved.

When blocking an inviter, the server MUST respond to the following endpoints with an error:

- `PUT /_matrix/federation/(v1|v2)/invite/{roomId}/{eventId}`
- `POST /_matrix/client/v3/rooms/{roomId}/invite`
- `POST /_matrix/client/v3/createRoom` (checking the `invite` list)
- `PUT /_matrix/client/v3/rooms/{roomId}/state/m.room.member/{stateKey}` (for invite membership)

The error SHOULD be `M_INVITE_BLOCKED` with a HTTP 403 status code.

When ignoring an invite, these endpoints MUST handle an invite normally as if accepted. However, the server
MUST NOT include the invite down client synchronization endpoints such as `GET /_matrix/client/v3/sync` or
MSC4186's sliding sync endpoint. In addition, these invites MUST be ignored when calculating push notifications.
Comment thread
Johennes marked this conversation as resolved.
For clarity, this means that the invited user will get a regular `invite` membership event in the target room
but will never be notified about that event, unless they modify their `m.invite_permission_config` such that the invite is no longer ignored. As with `m.ignored_user_list`, clients SHOULD perform an
initial `/sync` after relaxing their ignore configuration in order to receive potentially pending invites.

Otherwise, all other endpoints (such as `GET /_matrix/client/v3/rooms/{roomId}/state`) should work as before.

Servers are not expected to process these rules for appservice users when calculating events to send down
`PUT /_matrix/app/v1/transactions`. Appservices are not expected to be run directly by client users, and
should be able to handle their own spam prevention.

The semantics and order of evaluation enable a number of use cases, for instance:

```json5
// Invites from everyone
{
"type": "m.invite_permission_config",
"content": { }
}

// No invites at all
{
"type": "m.invite_permission_config",
"content": {
"blocked_servers": [ "*" ]
}
}

// Only invites from goodguys.org
{
"type": "m.invite_permission_config",
"content": {
"allowed_servers": [ "goodguys.org" ],
"blocked_servers": [ "*" ]
}
}

// Invites from everyone except badguys.org
{
"type": "m.invite_permission_config",
"content": {
"blocked_servers": [ "badguys.org" ]
}
}

Comment thread
Johennes marked this conversation as resolved.
// Only invites from goodguys.org except for @notactuallyguy:goodguys.org
{
"type": "m.invite_permission_config",
"content": {
"blocked_users": [ "@notactuallyguy:goodguys.org" ],
"allowed_servers": [ "goodguys.org" ]
"blocked_servers": [ "*" ]
}
}

// No invites from badguys.org unless it's @goodguy:badguys.org
{
"type": "m.invite_permission_config",
"content": {
"allowed_users": [ "@goodguy:badguys.org" ],
"blocked_servers": [ "badguys.org" ]
}
}

// Only invites from goodguys.org and don't provide feedback to reallybadguys.org
{
"type": "m.invite_permission_config",
"content": {
"allowed_servers": [ "goodguys.org" ],
"ignored_servers": [ "reallybadguys.org" ],
"blocked_servers": [ "*" ]
}
}
```

Comment thread
turt2live marked this conversation as resolved.
Servers MUST enforce `m.invite_permission_config` against incoming new invites. Additionally, Servers
SHOULD apply the config against existing pending invites as well.


## Potential issues
Comment thread
Johennes marked this conversation as resolved.

Enforcing the permission configuration exclusively on the server means users have no way to review
processed invites. This is desirable in most cases as a spam protection measure. It does mean, however,
that if the user has accidentally blocked a good actor and is informed about it through a different
communication channel, they'll have to update their permission configuration and request a re-invite.

The multitude of properties in `m.invite_permission_config` offers powerful configuration options. However,
making changes in complex configurations can lead to side effects that may be unanticipated for users. For
example, if the user already allowed `@alice:example.org` to send them invites and then adds a block for
`example.org` as a server, Alice can still send them invites which might be unexpected. To mitigate this,
clients that expose more advanced configuration interfaces SHOULD inform users about the impact of their
changes.

Comment thread
turt2live marked this conversation as resolved.

## Alternatives

Instead of introducing a separate account data event, the existing `m.ignored_user_list` could have
been expanded. This would, however, not only affect invites but also events in existing rooms which
makes it a much more nuclear option. Additionally, the existing schema of `m.ignored_user_list`
complicates morphing it into something that optionally supports allow-list semantics.

Regarding `m.invite_permission_config`, the split between user settings and server settings is
technically not needed because glob expressions are powerful enough to allow matching either.
Splitting them is more explicit and prevents unintended globbing mistakes, however. The fact that
a user glob and a server glob can overlap does not seem problematic because this proposal includes
a deterministic processing order for all settings.
Comment on lines +180 to +182
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's absolutely a problem, because presenting a meaningful UX for multiple overlapping settings is very difficult.

AFAICT, nobody has yet done so, which does little to persuade me it's possible.


A previous version of this proposal included a base setting of block / allow all with user and
server exceptions applied on top. In this scheme, flipping the base setting also inverts the semantics
of all exceptions, however, which makes changing the configuration quite complicated.
Comment thread
richvdh marked this conversation as resolved.

A comprehensive comparison of existing invite filtering proposals may be found in [MSC4192]. The
present proposal is functionally inferior to some of the alternatives outline there. It does, for
instance, not cover the change history of the permission config or sharing the config among different
users. The proposal is, however, a straightforward and easy to implement extension of the existing
`m.ignored_user_list` mechanism. See also [this comment] for further details. This proposal is additionally
extensible for further types of blocking in the future. For example, a future MSC could create definitions
and behaviours to block/ignore/allow invites from contacts, of a particular type (DM, space, etc),
to a particular room, or even with given keywords.


## Security considerations

None.


## Unstable prefix

Until this proposal is accepted into the spec, implementations should refer to `m.invite_permission_config`
and `m.invite_permission_config_enforced` as `org.matrix.msc4155.invite_permission_config` and
`org.matrix.msc4155.invite_permission_config_enforced`, respectively. Note that the [gematik specification],
which predates this MSC, uses an event type of `de.gematik.tim.account.permissionconfig.v1` and
a different event schema.

The error `M_INVITE_BLOCKED` should be `ORG.MATRIX.MSC4155.M_INVITE_BLOCKED` until this proposal is accepted into the spec.
Comment thread
Johennes marked this conversation as resolved.
## Dependencies

This proposal loosely depends on [MSC4283] for the semantics of "ignore" and "block".


[gematik specification]: https://github.com/gematik/api-ti-messenger/blob/9b9f21b87949e778de85dbbc19e25f53495871e2/src/schema/permissionConfig.json
[glob expressions]: https://spec.matrix.org/v1.14/appendices/#glob-style-matching
[MSC4192]: https://github.com/matrix-org/matrix-spec-proposals/pull/4192
[MSC4283]: https://github.com/matrix-org/matrix-spec-proposals/pull/4283
["Ignoring Users" module]: https://spec.matrix.org/v1.10/client-server-api/#ignoring-users
[this comment]: https://github.com/matrix-org/matrix-spec-proposals/pull/4192#discussion_r2025188127
[server ACLs]: https://spec.matrix.org/v1.15/client-server-api/#mroomserver_acl