-
Notifications
You must be signed in to change notification settings - Fork 434
MSC3860: Media Download Redirects #3860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 15 commits
ce59930
964c19e
088789b
916e1b3
9807bf4
6746c86
6767a51
aa14401
c9896a9
4b61481
c2e9d45
117f90c
bf2d22c
a7733d9
9312cb3
2b93616
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # MSC3860: Media Download Redirects | ||
|
anoadragon453 marked this conversation as resolved.
|
||
|
|
||
| Currently the media download endpoints must return either a 200 with content or error responses. This | ||
| means the media server instance must stream the data from wherever it is stored, which is likely not | ||
| local to itself. Allowing redirects on these endpoints would make it possible for the media repo to | ||
| tell clients/servers to pull data direct from the source, e.g. a CDN. | ||
|
anoadragon453 marked this conversation as resolved.
|
||
|
|
||
| Additionally redirects could be used to avoid downloading media from untrusted homeservers. Currently | ||
| users can make their homeserver download, cache and proxy any matrix mid that I want, including | ||
| bad/illegal content. Allowing for a 307 redirect would permit cautious server operators to not | ||
| store and provide any media that floats in the matrixverse, but just refer to the "original" media. | ||
|
|
||
| ## Proposal | ||
|
|
||
| This MSC proposes that a 307 or 308 redirect code is allowed and followed according to the `Location` | ||
| header. It is possible some clients would already follow these which needs to be confirmed. Specific | ||
| endpoints in question ([current spec link for these](https://spec.matrix.org/v1.6/client-server-api/#get_matrixmediav3downloadservernamemediaid)): | ||
|
|
||
| + `/_matrix/media/v3/download/{serverName}/{mediaId}` | ||
| + `/_matrix/media/v3/download/{serverName}/{mediaId}/{fileName}` | ||
| + `/_matrix/media/v3/thumbnail/{serverName}/{mediaId}` | ||
|
anoadragon453 marked this conversation as resolved.
|
||
|
|
||
| To prevent breaking clients that don't properly follow the redirect response this functionality will | ||
| be enabled by a query string flag `allow_redirect=true`. So specifically in the above cases if a | ||
| client respects redirect responses it can make requests like so to the media endpoints: | ||
|
anoadragon453 marked this conversation as resolved.
|
||
|
|
||
| + `/_matrix/media/v3/download/{serverName}/{mediaId}?allow_redirect=true` | ||
| + `/_matrix/media/v3/download/{serverName}/{mediaId}/{fileName}?allow_redirect=true` | ||
| + `/_matrix/media/v3/thumbnail/{serverName}/{mediaId}?allow_redirect=true` | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The next versioned media endpoints after this MSC gets accepted (e.g. if MSC3911 gets accepted) should drop the |
||
|
|
||
| In the case where a client wishes not to redirect (either implictly with no parameter or explicitly | ||
|
anoadragon453 marked this conversation as resolved.
Outdated
|
||
| providing `allow_redirect=false`) the server must continue to serve media directly with no redirect. | ||
|
|
||
| ## Potential Issues | ||
|
|
||
| None for clients, as opt-in functionality this change is 100% backwards compatible. | ||
|
|
||
| With redirects it becomes easier to force another homeserver to be your CDN, which isn't great | ||
| (clients could already do that, but not without recompiling). | ||
|
|
||
| Redirects also potentially allow changing of media underneath the users as different redirects could | ||
| be returned over time. It is worth noting that a badly behaving media server can already just return | ||
| different content as well. | ||
|
Comment on lines
+41
to
+43
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that this particular malicious behaviour could be squashed by deriving MXIDs from a hash of the media itself. MSC2846 proposes one such mechanism. |
||
|
|
||
| ## Alternatives | ||
|
|
||
| None at this time. | ||
|
|
||
| ## Security Considerations | ||
|
|
||
| A media repo could redirect requests to a bad actor, although this would make the primary media | ||
| repo itself a bad actor, thus this does not present any increased security issues. | ||
|
|
||
| ## Unstable Prefix | ||
|
|
||
| Until this functionality has landed in the spec, the `allow_redirect` query | ||
| parameter should be prefixed with `com.beeper.msc3860.`: | ||
|
|
||
| ``` | ||
| ?com.beeper.msc3860.allow_redirect=true | ||
| ``` | ||
Uh oh!
There was an error while loading. Please reload this page.